Skip to content

Commit a23355d

Browse files
authored
Remove NoAbstractMethodRule as way too opinionated (#121)
1 parent cb7c2cd commit a23355d

File tree

7 files changed

+1
-173
lines changed

7 files changed

+1
-173
lines changed

config/static-rules.neon

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ rules:
1111

1212
# paths
1313
- Symplify\PHPStanRules\Rules\NoMissingDirPathRule
14-
- Symplify\PHPStanRules\Rules\NoAbstractMethodRule
1514
- Symplify\PHPStanRules\Rules\NoReferenceRule
1615
- Symplify\PHPStanRules\Rules\NoArrayAccessOnObjectRule
1716

docs/rules_overview.md

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# 43 Rules Overview
1+
# 42 Rules Overview
22

33
## AnnotateRegexClassConstWithRegexLinkRule
44

@@ -550,38 +550,6 @@ final class SomeService
550550

551551
<br>
552552

553-
## NoAbstractMethodRule
554-
555-
Use explicit interface contract or a service over unclear abstract methods
556-
557-
- class: [`Symplify\PHPStanRules\Rules\NoAbstractMethodRule`](../src/Rules/NoAbstractMethodRule.php)
558-
559-
```php
560-
abstract class SomeClass
561-
{
562-
abstract public function run();
563-
}
564-
```
565-
566-
:x:
567-
568-
<br>
569-
570-
```php
571-
abstract class SomeClass implements RunnableInterface
572-
{
573-
}
574-
575-
interface RunnableInterface
576-
{
577-
public function run();
578-
}
579-
```
580-
581-
:+1:
582-
583-
<br>
584-
585553
## NoArrayAccessOnObjectRule
586554

587555
Use explicit methods over array access on object

src/Rules/NoAbstractMethodRule.php

Lines changed: 0 additions & 70 deletions
This file was deleted.

tests/Rules/NoAbstractMethodRule/Fixture/SkipNonAbstractMethod.php

Lines changed: 0 additions & 12 deletions
This file was deleted.

tests/Rules/NoAbstractMethodRule/Fixture/SomeAbstractMethod.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/NoAbstractMethodRule/NoAbstractMethodRuleTest.php

Lines changed: 0 additions & 42 deletions
This file was deleted.

tests/Rules/NoAbstractMethodRule/config/configured_rule.neon

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)