Fix wrongly encoding of URLs in links, images, and more

Previously, `normalize-uri` was used to decode and encode URLs.
Apparently, that doesn’t work very great.  Now, using `mdurl`
(from markdown-it) fixes the issue.

Closes remarkjs/remark#302.

Author: wooorm

lib/handlers/image-reference.js

@@ -2,7 +2,7 @@
 
 module.exports = imageReference;
 
-var normalize = require('normalize-uri');
+var normalize = require('mdurl/encode');
 var failsafe = require('../failsafe');
 
 /* Transform a reference to an image. */

lib/handlers/image.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var normalize = require('normalize-uri');
+var normalize = require('mdurl/encode');
 
 module.exports = image;
 

lib/handlers/link-reference.js

@@ -2,7 +2,7 @@
 
 module.exports = linkReference;
 
-var normalize = require('normalize-uri');
+var normalize = require('mdurl/encode');
 var failsafe = require('../failsafe');
 var all = require('../all');
 

lib/handlers/link.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var normalize = require('normalize-uri');
+var normalize = require('mdurl/encode');
 var all = require('../all');
 
 module.exports = link;

package.json

@@ -22,7 +22,7 @@
     "collapse-white-space": "^1.0.0",
     "detab": "^2.0.0",
     "mdast-util-definitions": "^1.2.0",
-    "normalize-uri": "^1.0.0",
+    "mdurl": "^1.0.1",
     "trim": "0.0.1",
     "trim-lines": "^1.0.0",
     "unist-builder": "^1.0.1",

test/link.js

@@ -27,5 +27,15 @@ test('Link', function (t) {
     'should transform `link` to `a` (missing `title`)'
   );
 
+  t.deepEqual(
+    to(u('link', {
+      url: 'https://github.com/facebook/react/pulls?q=is%3Apr%20is%3Aclosed'
+    }, [u('text', 'Alpha')])),
+    u('element', {tagName: 'a', properties: {
+      href: 'https://github.com/facebook/react/pulls?q=is%3Apr%20is%3Aclosed'
+    }}, [u('text', 'Alpha')]),
+    'should correctly decode/encode urls'
+  );
+
   t.end();
 });