fix ruby/prefer-endless-method for heredoc and def nodes

Author: flyerhzm

lib/ruby/prefer-endless-method.rb

@@ -23,7 +23,8 @@ def one_plus_one = 1 + 1
 
   within_files Synvert::ALL_RUBY_FILES + Synvert::ALL_RAKE_FILES do
     find_node '.def_node[body!=nil][body.body.length=1]' do
-      new_body = dedent(node.body.to_source)
+      body_column = mutation_adapter.get_start_loc(node.body.body.first).column
+      new_body = node.body.body.first.to_source.split("\n").map { |line| line.sub(/^ {#{body_column}}/, '') }.join("\n")
       replace_with "def {{name}}{{lparen}}{{parameters}}{{rparen}} = #{new_body}"
     end
   end

spec/ruby/prefer-endless-method_spec.rb

@@ -37,4 +37,52 @@ def existing_key(device) = transaction do
 
     include_examples 'convertable'
   end
+
+  context 'heredoc' do
+    let(:test_content) { <<~EOS }
+      def sample_gemfile_lock_content
+        <<~GEMFILE_LOCK
+          GEM
+            remote: https://rubygems.org/
+        GEMFILE_LOCK
+      end
+    EOS
+    let(:test_rewritten_content) { <<~EOS }
+      def sample_gemfile_lock_content = <<~GEMFILE_LOCK
+        GEM
+          remote: https://rubygems.org/
+      GEMFILE_LOCK
+    EOS
+
+    include_examples 'convertable'
+  end
+
+  context 'def inside class' do
+    let(:test_content) { <<~EOS }
+      class User
+        def generate_invitation_token
+          loop do
+            token = SecureRandom.hex(10)
+            unless Membership.exists?(invitation_token: token)
+              self.invitation_token = token
+              break
+            end
+          end
+        end
+      end
+    EOS
+    let(:test_rewritten_content) { <<~EOS }
+      class User
+        def generate_invitation_token = loop do
+          token = SecureRandom.hex(10)
+          unless Membership.exists?(invitation_token: token)
+            self.invitation_token = token
+            break
+          end
+        end
+      end
+    EOS
+
+    include_examples 'convertable'
+  end
 end