Skip to content

Commit 3d1607f

Browse files
committed
operator method works for ruby/prefer-endless-method
1 parent 38b99b1 commit 3d1607f

File tree

2 files changed

+18
-5
lines changed

2 files changed

+18
-5
lines changed

lib/ruby/prefer-endless-method.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def one_plus_one = 1 + 1
2323

2424
within_files Synvert::ALL_RUBY_FILES + Synvert::ALL_RAKE_FILES do
2525
find_node '.def_node[body!=nil][body.body.length=1]' do
26-
break if node.name.to_s.end_with?('=')
26+
break if node.name.to_s.match?(/[a-zA-Z]/) && node.name.to_s.end_with?('=')
2727
break if !node.parameters.nil? && node.lparen.nil? && node.rparen.nil?
2828

2929
first_body_node = node.body.body.first

spec/ruby/prefer-endless-method_spec.rb

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,13 +118,13 @@ def index
118118

119119
context 'do not process for or_node' do
120120
let(:test_content) { <<~EOS }
121-
def new_rating=(new_rating)
122-
self.rating = NEW_TO_OLD_MAPPER[new_rating] or raise "Unknown new rating"
121+
def new_rating(old_rating)
122+
NEW_TO_OLD_MAPPER[old_rating] or raise "Unknown new rating"
123123
end
124124
EOS
125125
let(:test_rewritten_content) { <<~EOS }
126-
def new_rating=(new_rating)
127-
self.rating = NEW_TO_OLD_MAPPER[new_rating] or raise "Unknown new rating"
126+
def new_rating(old_rating)
127+
NEW_TO_OLD_MAPPER[old_rating] or raise "Unknown new rating"
128128
end
129129
EOS
130130

@@ -178,6 +178,19 @@ def remove_item_ids=(item_ids)
178178
include_examples 'convertable'
179179
end
180180

181+
context 'process for operator method' do
182+
let(:test_content) { <<~EOS }
183+
def ==(other)
184+
true
185+
end
186+
EOS
187+
let(:test_rewritten_content) { <<~EOS }
188+
def ==(other) = true
189+
EOS
190+
191+
include_examples 'convertable'
192+
end
193+
181194
context 'do not process if parameter without parentheses' do
182195
let(:test_content) { <<~EOS }
183196
def initialize item

0 commit comments

Comments
 (0)