handle more cases for ruby/prefer-endless-method

Author: flyerhzm

lib/ruby/prefer-endless-method.rb

@@ -28,10 +28,11 @@ def one_plus_one = 1 + 1
 
       first_body_node = node.body.body.first
       break if %i[if_node unless_node].include?(first_body_node.type) && first_body_node.end_keyword.nil?
-      break if %i[multi_write_node instance_variable_or_write_node class_variable_or_write_node or_node and_node].include?(first_body_node.type)
+      break if %i[multi_write_node instance_variable_or_write_node class_variable_or_write_node or_node and_node hash_node].include?(first_body_node.type)
+      break if first_body_node.type == :call_node && first_body_node.opening.nil? && !first_body_node.arguments.nil? && first_body_node.closing.nil? && !first_body_node.block.nil?
 
       body_column = mutation_adapter.get_start_loc(first_body_node).column
-      new_body = node.body.body.first.to_source.split("\n").map { |line| line.sub(/^ {#{body_column}}/, '') }.join("\n")
+      new_body = first_body_node.to_source.split("\n").map { |line| line.sub(/^ {#{body_column}}/, '') }.join("\n")
       receiver_and_name = node.receiver ? "#{node.receiver.to_source}.#{node.name}" : node.name.to_s
       replace_with "def #{receiver_and_name}{{lparen}}{{parameters}}{{rparen}} = #{new_body}"
     end

spec/ruby/prefer-endless-method_spec.rb

@@ -154,6 +154,38 @@ def new_rating=(new_rating)
     include_examples 'convertable'
   end
 
+  context 'do not process for hash_node' do
+    let(:test_content) { <<~EOS }
+      def query
+        { foo: 'bar' }
+      end
+    EOS
+    let(:test_rewritten_content) { <<~EOS }
+      def query
+        { foo: 'bar' }
+      end
+    EOS
+
+    include_examples 'convertable'
+  end
+
+  context 'do not process for call_node without parentheses' do
+    let(:test_content) { <<~EOS }
+      def should_be_ignored
+        should 'be ignored' do
+        end
+      end
+    EOS
+    let(:test_rewritten_content) { <<~EOS }
+      def should_be_ignored
+        should 'be ignored' do
+        end
+      end
+    EOS
+
+    include_examples 'convertable'
+  end
+
   context 'do not process if name ends with =' do
     let(:test_content) { <<~EOS }
       def remove_item_ids=(item_ids)