rename find_classes_by_superclass to find_classes_by_ancestor

Author: flyerhzm

lib/helpers/parse_ruby.rb

@@ -3,7 +3,7 @@
 # ruby/parser helper parses ruby files and saves the :ruby_definitions to data.
 # The :ruby_definitions is an object of RubyDefinitions,
 # which contains all the classes, modules, methods, constants, ancestors,
-# and provides some methods, such as find_classes_by_superclass.
+# and provides some methods, such as find_classes_by_ancestor.
 Synvert::Helper.new 'ruby/parse' do |options|
   configure(parser: Synvert::PRISM_PARSER)
 
@@ -87,7 +87,7 @@
 class RubyDefinitions
   attr_reader :node
 
-  delegate :setup_ancestors, :find_classes_by_superclass, :to_h, to: :@root
+  delegate :setup_ancestors, :find_classes_by_ancestor, :to_h, to: :@root
 
   def initialize
     @root = RootDefinition.new
@@ -155,10 +155,10 @@ def current_node_type
 end
 
 class BaseDefinition
-  def find_classes_by_superclass(superclass)
+  def find_classes_by_ancestor(superclass)
     @classes.select { |klass| klass.ancestors.include?(superclass) } +
-      @classes.flat_map { |klass| klass.find_classes_by_superclass(superclass) } +
-      @modules.flat_map { |mod| mod.find_classes_by_superclass(superclass) }
+      @classes.flat_map { |klass| klass.find_classes_by_ancestor(superclass) } +
+      @modules.flat_map { |mod| mod.find_classes_by_ancestor(superclass) }
   end
 
   def full_name

lib/rails/perform_job_in_after_commit_callback.rb

@@ -31,9 +31,9 @@ def send_notification
 
   call_helper 'ruby/parse'
   definitions = load_data :ruby_definitions
-  job_classes = definitions.find_classes_by_superclass('ApplicationJob').map(&:full_name) +
-                definitions.find_classes_by_superclass('Sidekiq::Job').map(&:full_name)
-  mailer_classes = definitions.find_classes_by_superclass('ApplicationMailer').map(&:name)
+  job_classes = definitions.find_classes_by_ancestor('ApplicationJob').map(&:full_name) +
+                definitions.find_classes_by_ancestor('Sidekiq::Job').map(&:full_name)
+  mailer_classes = definitions.find_classes_by_ancestor('ApplicationMailer').map(&:name)
 
   within_files Synvert::RAILS_MODEL_FILES do
     find_node '.class_node' do

spec/helpers/parse_ruby_spec.rb

@@ -124,7 +124,7 @@ class UserJob < SynvertJob
     rewriter.process
 
     definitions = rewriter.load_data(:ruby_definitions)
-    classes = definitions.find_classes_by_superclass('ApplicationJob')
+    classes = definitions.find_classes_by_ancestor('ApplicationJob')
     expect(classes.map(&:full_name)).to eq(['SynvertJob', 'Synvert::UserJob'])
   end
 end