add rails/perform_job_in_after_commit_callback snippet

Author: flyerhzm

lib/rails/perform_job_in_after_commit_callback.rb

@@ -38,18 +38,32 @@ def send_notification
   within_files Synvert::RAILS_MODEL_FILES do
     find_node '.class_node' do
       callback_names_with_actions = {}
+      job_performed_def_names = []
 
       find_node node_type: 'call_node', receiver: nil, name: { in: %i[after_create after_update after_save] } do
         callback_names_with_actions[node.arguments.arguments.first.to_value.to_s] =
           NodeMutation::ReplaceAction.new(node, :name, with: '{{name}}_commit', adapter: mutation_adapter)
       end
 
-      find_node node_type: 'def_node', name: { in: callback_names_with_actions.keys } do
+      find_node node_type: 'def_node' do
         if_exist_node ".call_node[receiver=~/\\A(#{job_classes.join('|')})/][name IN (perform_later perform_async perform_in perform_at)]" do
-          add_action(callback_names_with_actions[node.name.to_s])
+          job_performed_def_names << node.name.to_s
         end
         if_exist_node ".call_node[receiver=~/\\A(#{mailer_classes.join('|')})/][name=deliver_later]" do
-          add_action(callback_names_with_actions[node.name.to_s])
+          job_performed_def_names << node.name.to_s
+        end
+      end
+
+      class_definition = definitions.find_class_by_full_name(node.full_name)
+      callback_names_with_actions.each do |callback_name, action|
+        if job_performed_def_names.include?(callback_name)
+          add_action(action)
+          next
+        end
+
+        method_definition = class_definition.find_method_by_name(callback_name)
+        if method_definition && method_definition.call_any_method?(job_performed_def_names)
+          add_action(action)
         end
       end
     end

spec/rails/perform_job_in_after_commit_callback_spec.rb

@@ -62,12 +62,16 @@ class User < ApplicationRecord
         after_save :update_cache
 
         def send_notification
-          NotificationJob.perform_async(self)
+          notify_user
         end
 
         def update_cache
           Cache.update(self)
         end
+
+        def notify_user
+          NotificationJob.perform_async(self)
+        end
       end
     EOF
     let(:test_rewritten_contents) { [<<~EOF.strip, <<~EOF.strip] }
@@ -83,12 +87,16 @@ class User < ApplicationRecord
         after_save :update_cache
 
         def send_notification
-          NotificationJob.perform_async(self)
+          notify_user
         end
 
         def update_cache
           Cache.update(self)
         end
+
+        def notify_user
+          NotificationJob.perform_async(self)
+        end
       end
     EOF