Skip to content

Commit 157ded5

Browse files
author
Matt Land
committed
test cleanup
1 parent b008a72 commit 157ded5

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

adafruit_imageload/tests/test_pnm_load.py

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,43 +12,38 @@ def __init__(self, width, height, colors):
1212

1313
logging.getLogger().setLevel(logging.INFO)
1414

15-
class TestPbmP1(TestCase):
15+
class TestPnmLoad(TestCase):
1616

1717
def test_load_fails_with_no_header_data(self):
1818
f = BytesIO(b"some initial binary data: \x00\x01")
1919
try:
20-
pnm.load(f, b'P1')
20+
pnm.load(f, b'P1', bitmap=Bitmap)
2121
self.fail('should have failed')
2222
except Exception as e:
2323
if "Unsupported image format" not in str(e):
2424
raise
2525

26-
def _test_load_works_p1_ascii(self):
26+
def test_load_works_p1_ascii(self):
2727
test_file = os.path.join(os.path.dirname(__file__), '..', '..', 'examples', 'images', 'netpbm_p1_mono.pbm')
28-
with open(test_file) as f:
29-
f.seek(2)
30-
bitmap, palette = pnm.load(f, b'P1')
31-
self.assertTrue(isinstance(bitmap, Bitmap))
32-
self.fail(bitmap)
28+
with open(test_file, 'rb') as f:
29+
bitmap, palette = pnm.load(f, b'P1', bitmap=Bitmap)
30+
self.assertTrue(isinstance(bitmap, Bitmap), bitmap)
3331
self.assertEqual(1, bitmap.colors)
34-
self.assertEqual(20, bitmap.width)
32+
self.assertEqual(13, bitmap.width)
33+
self.assertEqual(21, bitmap.height)
3534

3635
def test_load_works_p4_binary(self):
3736
test_file = os.path.join(os.path.dirname(__file__), '..', '..', 'examples', 'images', 'netpbm_p4_mono.pbm')
38-
3937
with open(test_file, 'rb') as f:
40-
f.seek(2)
4138
bitmap, palette = pnm.load(f, b'P4', bitmap=Bitmap)
4239
self.assertTrue(isinstance(bitmap, Bitmap))
4340
self.assertEqual(1, bitmap.colors)
4441
self.assertEqual(8, bitmap.width)
4542
self.assertEqual(8, bitmap.height)
4643

47-
def test_load_works_p4_binary_big(self):
44+
def test_load_works_p4_binary_high_res(self):
4845
test_file = os.path.join(os.path.dirname(__file__), '..', '..', 'examples', 'images', 'MARBLES.PBM')
49-
5046
with open(test_file, 'rb') as f:
51-
f.seek(2)
5247
bitmap, palette = pnm.load(f, b'P4', bitmap=Bitmap)
5348
self.assertTrue(isinstance(bitmap, Bitmap))
5449
self.assertEqual(1, bitmap.colors)

0 commit comments

Comments
 (0)