Merge pull request #341 from technote-space/release/next-v4.4.1

release: v4.4.2

Author: technote-space

__tests__/api-helper1.test.ts

@@ -1,8 +1,8 @@
 /* eslint-disable no-magic-numbers */
 import nock from 'nock';
 import path from 'path';
-import {Utils} from '../src';
 import {
+  getOctokit,
   disableNetConnect,
   testEnv,
   getContext,
@@ -13,9 +13,10 @@ import {
   exportVariableCalledWith,
 } from '@technote-space/github-action-test-helper';
 import {Logger} from '@technote-space/github-action-log-helper';
-import {GitCreateCommitResponseData} from '@octokit/types';
+import {components} from '@octokit/openapi-types';
 import {ApiHelper} from '../src';
 
+type GitCreateCommitResponseData = components['schemas']['git-commit'];
 const rootDir = path.resolve(__dirname, 'fixtures');
 const context = getContext({
   ref: 'refs/heads/test',
@@ -32,7 +33,7 @@ const context = getContext({
     number: 123,
   },
 });
-const octokit = Utils.getOctokit('test-token');
+const octokit = getOctokit();
 const logger  = new Logger();
 
 const createCommitResponse: GitCreateCommitResponseData = {
@@ -162,6 +163,7 @@ describe('ApiHelper', () => {
 
       const commit = await helper.createCommit('test commit message', {
         sha: 'tree-sha',
+        truncated: true,
         tree: [],
         url: '',
       });
@@ -198,6 +200,7 @@ describe('ApiHelper', () => {
       }), logger);
       const commit = await helper.createCommit('test commit message', {
         sha: 'tree-sha',
+        truncated: true,
         tree: [],
         url: '',
       });

__tests__/api-helper2.test.ts

@@ -1,8 +1,8 @@
 /* eslint-disable no-magic-numbers */
 import nock from 'nock';
 import path from 'path';
-import {Utils} from '../src';
 import {
+  getOctokit,
   disableNetConnect,
   testEnv,
   getContext,
@@ -11,9 +11,10 @@ import {
   stdoutCalledWith,
 } from '@technote-space/github-action-test-helper';
 import {Logger} from '@technote-space/github-action-log-helper';
-import {GitCreateCommitResponseData} from '@octokit/types';
+import {components} from '@octokit/openapi-types';
 import {ApiHelper} from '../src';
 
+type GitCreateCommitResponseData = components['schemas']['git-commit'];
 const rootDir = path.resolve(__dirname, 'fixtures');
 const context = getContext({
   ref: 'refs/heads/test',
@@ -33,7 +34,7 @@ const context = getContext({
     },
   },
 });
-const octokit = Utils.getOctokit('test-token');
+const octokit = getOctokit();
 const logger  = new Logger();
 
 const createCommitResponse: GitCreateCommitResponseData = {

__tests__/utils2.test.ts

@@ -2,8 +2,8 @@
 import {testEnv} from '@technote-space/github-action-test-helper';
 import {Utils} from '../src';
 
-const {generateNewPatchVersion, generateNewMinorVersion, generateNewMajorVersion, arrayChunk, versionCompare, isCommandDebug, isOutputDebug} = Utils;
-const {isBranch, isTagRef, normalizeRef, trimRef, getTag, getRefspec, getRemoteRefspec, getLocalRefspec, getOctokit, replaceVariables, mask} = Utils;
+const {generateNewPatchVersion, generateNewMinorVersion, generateNewMajorVersion, arrayChunk, versionCompare, isCommandDebug, isOutputDebug, objectGet}     = Utils;
+const {isBranch, isTagRef, normalizeRef, trimRef, getTag, getRefspec, getRemoteRefspec, getLocalRefspec, getOctokit, replaceVariables, mask, ensureNotNull} = Utils;
 
 jest.useFakeTimers();
 
@@ -319,3 +319,27 @@ describe('isOutputDebug', () => {
     expect(isOutputDebug()).toBe(false);
   });
 });
+
+describe('ensureNotNull', () => {
+  it('should return value', () => {
+    expect(ensureNotNull('test')).toBe('test');
+  });
+
+  it('should return empty string', () => {
+    expect(ensureNotNull(null)).toBe('');
+    expect(ensureNotNull(undefined)).toBe('');
+  });
+});
+
+describe('objectGet', () => {
+  it('should return object value', () => {
+    expect(objectGet({test1: {test2: 123}}, 'test1')).toEqual({test2: 123});
+    expect(objectGet({test1: {test2: 123}}, 'test1.test2')).toBe(123);
+  });
+
+  it('should return undefined', () => {
+    expect(objectGet(undefined, 'test1.test2')).toBeUndefined();
+    expect(objectGet({test1: {test2: 123}}, '')).toBeUndefined();
+    expect(objectGet({test1: {test2: 123}}, 'test1.test3')).toBeUndefined();
+  });
+});

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@technote-space/github-action-helper",
-  "version": "4.4.1",
+  "version": "4.4.2",
   "description": "Helper for GitHub Action.",
   "keywords": [
     "github",
@@ -36,24 +36,25 @@
   "dependencies": {
     "@actions/core": "^1.2.6",
     "@actions/github": "^4.0.0",
-    "@octokit/plugin-rest-endpoint-methods": "^4.2.1",
-    "@technote-space/github-action-log-helper": "^0.1.8",
+    "@octokit/openapi-types": "^2.0.0",
+    "@octokit/plugin-rest-endpoint-methods": "^4.4.1",
+    "@technote-space/github-action-log-helper": "^0.1.9",
     "shell-escape": "^0.2.0",
     "sprintf-js": "^1.1.2"
   },
   "devDependencies": {
     "@commitlint/cli": "^11.0.0",
     "@commitlint/config-conventional": "^11.0.0",
-    "@technote-space/github-action-test-helper": "^0.6.4",
-    "@types/jest": "^26.0.15",
-    "@types/node": "^14.14.9",
-    "@typescript-eslint/eslint-plugin": "^4.8.2",
-    "@typescript-eslint/parser": "^4.8.2",
-    "eslint": "^7.14.0",
-    "husky": "^4.3.0",
+    "@technote-space/github-action-test-helper": "^0.6.5",
+    "@types/jest": "^26.0.16",
+    "@types/node": "^14.14.10",
+    "@typescript-eslint/eslint-plugin": "^4.9.0",
+    "@typescript-eslint/parser": "^4.9.0",
+    "eslint": "^7.15.0",
+    "husky": "^4.3.4",
     "jest": "^26.6.3",
     "jest-circus": "^26.6.3",
-    "lint-staged": "^10.5.2",
+    "lint-staged": "^10.5.3",
     "nock": "^13.0.5",
     "ts-jest": "^26.4.4",
     "typescript": "^4.1.2"

src/api-helper.ts

@@ -3,24 +3,34 @@ import path from 'path';
 import {Context} from '@actions/github/lib/context';
 import {PaginateInterface} from '@octokit/plugin-paginate-rest';
 import {RestEndpointMethods} from '@octokit/plugin-rest-endpoint-methods/dist-types/generated/method-types';
-import {
-  OctokitResponse,
-  GitGetCommitResponseData,
-  PullsGetResponseData,
-  GitCreateTreeResponseData,
-  GitCreateCommitResponseData,
-  GitGetRefResponseData,
-  PullsListResponseData,
-  PullsCreateResponseData,
-  PullsUpdateResponseData,
-  GitListMatchingRefsResponseData,
-} from '@octokit/types';
+import {OctokitResponse} from '@octokit/types';
+import {components} from '@octokit/openapi-types';
 import {exportVariable} from '@actions/core';
 import {Logger} from '@technote-space/github-action-log-helper';
-import {getRefForUpdate, isPrRef, getBranch, trimRef, versionCompare, generateNewPatchVersion, generateNewMajorVersion, generateNewMinorVersion} from './utils';
+import {
+  getRefForUpdate,
+  isPrRef,
+  getBranch,
+  trimRef,
+  versionCompare,
+  generateNewPatchVersion,
+  generateNewMajorVersion,
+  generateNewMinorVersion,
+  ensureNotNull,
+  objectGet,
+} from './utils';
 import {getSender} from './context-helper';
 import {Octokit} from './types';
 
+type GitGetCommitResponseData = components['schemas']['git-commit'];
+type PullsGetResponseData = components['schemas']['pull-request'];
+type GitCreateTreeResponseData = components['schemas']['git-tree'];
+type GitCreateCommitResponseData = components['schemas']['git-commit'];
+type GitGetRefResponseData = components['schemas']['git-ref'];
+type PullsListResponseData = components['schemas']['pull-request-simple'];
+type PullsCreateResponseData = components['schemas']['pull-request'];
+type PullsUpdateResponseData = components['schemas']['pull-request'];
+
 type PullsUpdateParams = {
   body?: string;
   draft?: boolean;
@@ -163,18 +173,18 @@ export default class ApiHelper {
   /**
    * @param {string} rootDir root dir
    * @param {object} files files
-   * @return {Promise<{ path: string, sha: string }[]>} blobs
+   * @return {Promise<Array<{ path: string, sha: string }>>} blobs
    */
-  public filesToBlobs = async(rootDir: string, files: Array<string>): Promise<{ path: string; sha: string }[]> => await Promise.all(Object.values(files).map(file => this.createBlob(rootDir, file)));
+  public filesToBlobs = async(rootDir: string, files: Array<string>): Promise<Array<{ path: string; sha: string }>> => await Promise.all(files.map(file => this.createBlob(rootDir, file)));
 
   /**
-   * @param {{ path: string, sha: string }[]} blobs blobs
+   * @param {Array<{ path: string, sha: string }>} blobs blobs
    * @return {Promise<GitCreateTreeResponseData>} tree
    */
-  public createTree = async(blobs: { path: string; sha: string }[]): Promise<GitCreateTreeResponseData> => this.getResponseData((this.octokit as RestEndpointMethods).git.createTree({
+  public createTree = async(blobs: Array<{ path: string; sha: string }>): Promise<GitCreateTreeResponseData> => this.getResponseData((this.octokit as RestEndpointMethods).git.createTree({
     ...this.context.repo,
-    'base_tree': (await this.getCommit()).tree.sha,
-    tree: Object.values(blobs).map(blob => ({
+    'base_tree': ensureNotNull(objectGet((await this.getCommit()), 'tree.sha')),
+    tree: blobs.map(blob => ({
       path: blob.path,
       type: 'blob',
       mode: '100644',
@@ -220,7 +230,7 @@ export default class ApiHelper {
       await (this.octokit as RestEndpointMethods).git.updateRef({
         ...this.context.repo,
         ref: refName,
-        sha: commit.sha,
+        sha: ensureNotNull(commit.sha),
         force,
       });
 
@@ -245,7 +255,7 @@ export default class ApiHelper {
     await (this.octokit as RestEndpointMethods).git.createRef({
       ...this.context.repo,
       ref: refName,
-      sha: commit.sha,
+      sha: ensureNotNull(commit.sha),
     });
   };
 
@@ -264,7 +274,7 @@ export default class ApiHelper {
    * @param {string} branchName branch name
    * @return {Promise<PullsListResponseData | null>} pull request
    */
-  public findPullRequest = async(branchName: string): Promise<PullsListResponseData[number] | null> => {
+  public findPullRequest = async(branchName: string): Promise<PullsListResponseData | null> => {
     const response = await (this.octokit as RestEndpointMethods).pulls.list({
       ...this.context.repo,
       head: `${this.context.repo.owner}:${getBranch(branchName, false)}`,
@@ -278,9 +288,9 @@ export default class ApiHelper {
 
   /**
    * @param {PullsListParams} params params
-   * @return {AsyncIterable<PullsListResponseData>} pull request list
+   * @return {AsyncIterable<Array<PullsListResponseData>>} pull request list
    */
-  public pullsList = (params: PullsListParams): Promise<PullsListResponseData> => (this.octokit.paginate as PaginateInterface)(
+  public pullsList = (params: PullsListParams): Promise<Array<PullsListResponseData>> => (this.octokit.paginate as PaginateInterface)(
     (this.octokit as RestEndpointMethods).pulls.list,
     Object.assign({
       sort: 'created',
@@ -403,10 +413,10 @@ export default class ApiHelper {
   private isProtectedBranchError = (error: Error): boolean => /required status checks?.* (is|are) expected/i.test(error.message);
 
   /**
-   * @param {string[]} files files
+   * @param {Array<string>} files files
    * @return {boolean} diff?
    */
-  private checkDiff = (files: string[]): boolean => {
+  private checkDiff = (files: Array<string>): boolean => {
     if (!files.length) {
       this.callLogger(logger => logger.info('There is no diff.'));
       return false;
@@ -418,10 +428,10 @@ export default class ApiHelper {
   /**
    * @param {string} rootDir root dir
    * @param {string} commitMessage commit message
-   * @param {string[]} files files
+   * @param {Array<string>} files files
    * @return {Promise<GitCreateCommitResponseData>} commit
    */
-  private prepareCommit = async(rootDir: string, commitMessage: string, files: string[]): Promise<GitCreateCommitResponseData> => {
+  private prepareCommit = async(rootDir: string, commitMessage: string, files: Array<string>): Promise<GitCreateCommitResponseData> => {
     this.callLogger(logger => logger.startProcess('Creating blobs...'));
     const blobs = await this.filesToBlobs(rootDir, files);
 
@@ -435,10 +445,10 @@ export default class ApiHelper {
   /**
    * @param {string} rootDir root dir
    * @param {string} commitMessage commit message
-   * @param {string[]} files files
+   * @param {Array<string>} files files
    * @return {Promise<boolean>} result
    */
-  public commit = async(rootDir: string, commitMessage: string, files: string[]): Promise<boolean> => {
+  public commit = async(rootDir: string, commitMessage: string, files: Array<string>): Promise<boolean> => {
     if (!this.checkDiff(files)) {
       return false;
     }
@@ -459,12 +469,12 @@ export default class ApiHelper {
   /**
    * @param {string} rootDir root dir
    * @param {string} commitMessage commit message
-   * @param {string[]} files files
+   * @param {Array<string>} files files
    * @param {string} createBranchName branch name
    * @param {PullsCreateParams} detail detail
    * @return {Promise<boolean|PullsInfo>} result
    */
-  public createPR = async(rootDir: string, commitMessage: string, files: string[], createBranchName: string, detail: PullsCreateParams): Promise<boolean | PullsInfo> => {
+  public createPR = async(rootDir: string, commitMessage: string, files: Array<string>, createBranchName: string, detail: PullsCreateParams): Promise<boolean | PullsInfo> => {
     if (!this.checkDiff(files)) {
       return false;
     }
@@ -530,8 +540,8 @@ export default class ApiHelper {
 
     return {
       login: user.login,
-      email: user.email,
-      name: user.name,
+      email: ensureNotNull(user.email),
+      name: ensureNotNull(user.name),
       id: user.id,
     };
   };
@@ -552,7 +562,7 @@ export default class ApiHelper {
       ...this.context.repo,
       ref: 'tags/',
     },
-  )).map((item): string => trimRef((item as GitListMatchingRefsResponseData[number]).ref));
+  )).map((item): string => trimRef(item.ref));
 
   /**
    * @return {Promise<string>} tag

src/utils.ts

@@ -256,3 +256,22 @@ export const replaceVariables = async(string: string, variables: { key: string;
 export const isCommandDebug = (): boolean => getInput('UTILS_COMMAND_DEBUG') === 'true';
 
 export const isOutputDebug = (): boolean => getInput('UTILS_OUTPUT_DEBUG') === 'true';
+
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+export const objectGet = <T>(value: { [key: string]: any } | undefined, key: string): T | undefined => {
+  const keys = key.split('.');
+
+  if (!keys.length || !value || !(keys[0] in value)) {
+    return undefined;
+  }
+
+  // eslint-disable-next-line no-magic-numbers
+  if (keys.length > 1) {
+    // eslint-disable-next-line no-magic-numbers
+    return objectGet(value[keys[0]], keys.slice(1).join('.'));
+  }
+
+  return value[keys[0]];
+};
+
+export const ensureNotNull = (value: string | null | undefined): string => value ?? '';

tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     /* Basic Options */
     // "incremental": true,                   /* Enable incremental compilation */
-    "target": "es6",
+    "target": "ES2019",
     /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */
     "module": "commonjs",
     /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */