Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Commit 0fd2a1e

Browse files
authored
build: mark the library as shared (#1056)
Mark the imported library as shared in the hopes that this will force the Windows build to use the import library rather than the DLL for the linker input.
1 parent 7dccb8a commit 0fd2a1e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ if(ENABLE_PYTHON_SUPPORT)
102102
ExternalProject_Get_Property(python-kit BINARY_DIR)
103103
ExternalProject_Get_Property(python-kit SOURCE_DIR)
104104

105-
add_library(PythonKit IMPORTED UNKNOWN)
105+
add_library(PythonKit SHARED IMPORTED)
106106
set_target_properties(PythonKit PROPERTIES
107107
IMPORTED_LOCATION ${BINARY_DIR}/PythonKit/${CMAKE_SHARED_LIBRARY_PREFIX}PythonKit${CMAKE_SHARED_LIBRARY_SUFFIX}
108108
IMPORTED_IMPLIB ${BINARY_DIR}/PythonKit/${CMAKE_IMPORT_LIBRARY_PREFIX}PythonKit${CMAKE_IMPORT_LIBRARY_SUFFIX}
@@ -172,7 +172,7 @@ if(NOT X10_FOUND AND NOT USE_BUNDLED_X10)
172172
${SOURCE_DIR}/bazel-libtensorflow/external/com_google_absl
173173
${SOURCE_DIR}/bazel-libtensorflow/external/com_google_protobuf/src
174174
${SOURCE_DIR}/bazel-libtensorflow/external/eigen_archive)
175-
add_library(x10 IMPORTED UNKNOWN)
175+
add_library(x10 SHARED IMPORTED)
176176
set_target_properties(x10 PROPERTIES
177177
IMPORTED_LOCATION ${X10_LIBRARY}
178178
INTERFACE_INCLUDE_DIRECTORIES "${X10_INCLUDE_DIRS}")

0 commit comments

Comments
 (0)