Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Fix test failures related to Optional: KeyPathIterable conformance #1112

Merged
merged 3 commits into from
Oct 30, 2020
Merged

Fix test failures related to Optional: KeyPathIterable conformance #1112

merged 3 commits into from
Oct 30, 2020

Conversation

texasmichelle
Copy link
Member

@texasmichelle texasmichelle commented Oct 29, 2020 •
edited
Loading

Uses the same fix as #1090 to resolve the warning:

/home/michellecasbon/repos/swift-apis/Sources/x10/swift_bindings/apis/CrossReplicaSum.swift:52:49: warning: conditional cast from 'Any?' to '_KeyPathIterableBase' always succeeds
      } else if let nested = self[keyPath: nkp] as? _KeyPathIterableBase {
                                                ^

@texasmichelle texasmichelle changed the title Remove unnecessary conditional Fix test failures related to Optional: KeyPathIterable conformance Oct 30, 2020
@texasmichelle texasmichelle merged commit 2887964 into tensorflow:master Oct 30, 2020
@texasmichelle texasmichelle deleted the kpi_warning branch October 30, 2020 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BradLarson BradLarson BradLarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texasmichelle @BradLarson