replace OrderedDict with dict

This change replaces `OrderedDict` with `dict` as done in
encode/django-rest-framework#8964. This does not
look like it has been released yet, but since this package requires
Python 3.8 which is > Python 3.5, which was the last release to need
`OrderedDict`, then this change should be safe to merge now. It should
also be safe because `dict` is a superclass of `OrderedDict` and should
not change anything for users who are using `OrderedDict` still.

Author: terencehonles

rest_framework-stubs/fields.pyi

@@ -1,6 +1,5 @@
 import datetime
 import uuid
-from collections import OrderedDict
 from collections.abc import Callable, Generator, Iterable, Mapping, MutableMapping, Sequence
 from decimal import Decimal
 from enum import Enum
@@ -46,10 +45,10 @@ class Option(Protocol):
 def is_simple_callable(obj: Callable) -> bool: ...
 def get_attribute(instance: Any, attrs: list[str] | None) -> Any: ...
 def set_value(dictionary: MutableMapping[str, Any], keys: Sequence[str], value: Any) -> None: ...
-def to_choices_dict(choices: Iterable[Any]) -> OrderedDict: ...
-def flatten_choices_dict(choices: dict[Any, Any]) -> OrderedDict: ...
+def to_choices_dict(choices: Iterable[Any]) -> dict: ...
+def flatten_choices_dict(choices: dict[Any, Any]) -> dict: ...
 def iter_options(
-    grouped_choices: OrderedDict, cutoff: int | None = ..., cutoff_text: StrOrPromise | None = ...
+    grouped_choices: dict, cutoff: int | None = ..., cutoff_text: StrOrPromise | None = ...
 ) -> Generator[Option, None, None]: ...
 def get_error_detail(exc_info: Any) -> Any: ...
 
@@ -454,9 +453,9 @@ class ChoiceField(Field[str, str | int | tuple[str | int, str | int | tuple], st
     html_cutoff: int | None
     html_cutoff_text: StrOrPromise | None
     allow_blank: bool
-    grouped_choices: OrderedDict
+    grouped_choices: dict
     choice_strings_to_values: dict[str, Any]
-    _choices: OrderedDict
+    _choices: dict
     def __init__(
         self,
         choices: Iterable[Any],

rest_framework-stubs/relations.pyi

@@ -1,4 +1,3 @@
-from collections import OrderedDict
 from collections.abc import Callable, Iterable, Mapping, Sequence
 from typing import Any, Generic, TypeVar
 
@@ -62,11 +61,11 @@ class RelatedField(Generic[_MT, _DT, _PT], Field[_MT, _DT, _PT, Any]):
     def many_init(cls, *args: Any, **kwargs: Any) -> ManyRelatedField: ...
     def get_queryset(self) -> QuerySet[_MT]: ...
     def use_pk_only_optimization(self) -> bool: ...
-    def get_choices(self, cutoff: int | None = ...) -> OrderedDict: ...
+    def get_choices(self, cutoff: int | None = ...) -> dict: ...
     @property
-    def choices(self) -> OrderedDict: ...
+    def choices(self) -> dict: ...
     @property
-    def grouped_choices(self) -> OrderedDict: ...
+    def grouped_choices(self) -> dict: ...
     def iter_options(self) -> Iterable[Option]: ...
     def get_attribute(self, instance: _MT) -> _PT | None: ...  # type: ignore[override]
     def display_value(self, instance: _MT) -> str: ...
@@ -182,9 +181,9 @@ class ManyRelatedField(Field[Sequence[Any], Sequence[Any], list[Any], Any]):
         child_relation: RelatedField = ...,
     ): ...
     def get_value(self, dictionary: Mapping[Any, Any]) -> list[Any]: ...  # type: ignore[override]
-    def get_choices(self, cutoff: int | None = ...) -> OrderedDict: ...
+    def get_choices(self, cutoff: int | None = ...) -> dict: ...
     @property
-    def choices(self) -> OrderedDict: ...
+    def choices(self) -> dict: ...
     @property
-    def grouped_choices(self) -> OrderedDict: ...
+    def grouped_choices(self) -> dict: ...
     def iter_options(self) -> Iterable[Option]: ...

rest_framework-stubs/schemas/coreapi.pyi

@@ -1,4 +1,4 @@
-from collections import Counter, OrderedDict
+from collections import Counter
 from collections.abc import Iterable, Sequence
 from typing import Any
 
@@ -17,7 +17,7 @@ def distribute_links(obj: Any) -> None: ...
 
 INSERT_INTO_COLLISION_FMT: str
 
-class LinkNode(OrderedDict):
+class LinkNode(dict):
     links: list[Any]
     methods_counter: Counter
     def __init__(self) -> None: ...

rest_framework-stubs/utils/serializer_helpers.pyi

@@ -1,12 +1,11 @@
-from collections import OrderedDict
 from collections.abc import Iterator, MutableMapping
 from typing import Any
 
 from rest_framework.exceptions import ErrorDetail
 from rest_framework.fields import Field
 from rest_framework.serializers import BaseSerializer
 
-class ReturnDict(OrderedDict):
+class ReturnDict(dict):
     serializer: BaseSerializer
     def __init__(self, serializer: BaseSerializer = ..., *args, **kwargs): ...
     def copy(self) -> ReturnDict: ...
@@ -39,7 +38,7 @@ class NestedBoundField(BoundField):
 
 class BindingDict(MutableMapping[str, Field]):
     serializer: BaseSerializer
-    fields: OrderedDict[str, Field]
+    fields: dict[str, Field]
     def __init__(self, serializer: BaseSerializer): ...
     def __setitem__(self, key: str, field: Field) -> None: ...
     def __getitem__(self, key: str) -> Field: ...

rest_framework-stubs/viewsets.pyi

@@ -1,4 +1,3 @@
-from collections import OrderedDict
 from collections.abc import Callable
 from typing import Any
 
@@ -36,7 +35,7 @@ class ViewSetMixin:
     def reverse_action(self, url_name: str, *args: Any, **kwargs: Any) -> str: ...
     @classmethod
     def get_extra_actions(cls) -> list[_ViewFunc]: ...
-    def get_extra_action_url_map(self) -> OrderedDict[str, str]: ...
+    def get_extra_action_url_map(self) -> dict[str, str]: ...
 
 class ViewSet(ViewSetMixin, views.APIView): ...
 class GenericViewSet(ViewSetMixin, generics.GenericAPIView[_MT_co]): ...