fix: Do not create cors_configuration when variable not provided (#114)

Co-authored-by: Bryant Biggs <[email protected]>

Author: durnik-ivo

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/antonbabenko/pre-commit-terraform
-    rev: v1.92.0
+    rev: v1.92.1
     hooks:
       - id: terraform_fmt
       - id: terraform_wrapper_module_for_each

README.md

@@ -204,7 +204,7 @@ module "api_gateway" {
 | <a name="input_api_version"></a> [api\_version](#input\_api\_version) | A version identifier for the API. Must be between 1 and 64 characters in length | `string` | `null` | no |
 | <a name="input_authorizers"></a> [authorizers](#input\_authorizers) | Map of API gateway authorizers to create | <pre>map(object({<br>    authorizer_credentials_arn        = optional(string)<br>    authorizer_payload_format_version = optional(string)<br>    authorizer_result_ttl_in_seconds  = optional(number)<br>    authorizer_type                   = optional(string, "REQUEST")<br>    authorizer_uri                    = optional(string)<br>    enable_simple_responses           = optional(bool)<br>    identity_sources                  = optional(list(string))<br>    jwt_configuration = optional(object({<br>      audience = optional(list(string))<br>      issuer   = optional(string)<br>    }))<br>    name = optional(string)<br>  }))</pre> | `{}` | no |
 | <a name="input_body"></a> [body](#input\_body) | An OpenAPI specification that defines the set of routes and integrations to create as part of the HTTP APIs. Supported only for HTTP APIs | `string` | `null` | no |
-| <a name="input_cors_configuration"></a> [cors\_configuration](#input\_cors\_configuration) | The cross-origin resource sharing (CORS) configuration. Applicable for HTTP APIs | <pre>object({<br>    allow_credentials = optional(bool)<br>    allow_headers     = optional(list(string))<br>    allow_methods     = optional(list(string))<br>    allow_origins     = optional(list(string))<br>    expose_headers    = optional(list(string), [])<br>    max_age           = optional(number)<br>  })</pre> | `{}` | no |
+| <a name="input_cors_configuration"></a> [cors\_configuration](#input\_cors\_configuration) | The cross-origin resource sharing (CORS) configuration. Applicable for HTTP APIs | <pre>object({<br>    allow_credentials = optional(bool)<br>    allow_headers     = optional(list(string))<br>    allow_methods     = optional(list(string))<br>    allow_origins     = optional(list(string))<br>    expose_headers    = optional(list(string), [])<br>    max_age           = optional(number)<br>  })</pre> | `null` | no |
 | <a name="input_create"></a> [create](#input\_create) | Controls if resources should be created | `bool` | `true` | no |
 | <a name="input_create_certificate"></a> [create\_certificate](#input\_create\_certificate) | Whether to create a certificate for the domain | `bool` | `true` | no |
 | <a name="input_create_domain_name"></a> [create\_domain\_name](#input\_create\_domain\_name) | Whether to create API domain name resource | `bool` | `true` | no |

main.tf

@@ -16,7 +16,7 @@ resource "aws_apigatewayv2_api" "this" {
   body                         = local.is_http ? var.body : null
 
   dynamic "cors_configuration" {
-    for_each = local.is_http && length(var.cors_configuration) > 0 ? [var.cors_configuration] : []
+    for_each = local.is_http && var.cors_configuration != null ? [var.cors_configuration] : []
 
     content {
       allow_credentials = cors_configuration.value.allow_credentials

variables.tf

@@ -30,7 +30,7 @@ variable "cors_configuration" {
     expose_headers    = optional(list(string), [])
     max_age           = optional(number)
   })
-  default = {}
+  default = null
 }
 
 variable "credentials_arn" {

wrappers/main.tf

@@ -8,7 +8,7 @@ module "wrapper" {
   api_version                                        = try(each.value.api_version, var.defaults.api_version, null)
   authorizers                                        = try(each.value.authorizers, var.defaults.authorizers, {})
   body                                               = try(each.value.body, var.defaults.body, null)
-  cors_configuration                                 = try(each.value.cors_configuration, var.defaults.cors_configuration, {})
+  cors_configuration                                 = try(each.value.cors_configuration, var.defaults.cors_configuration, null)
   create                                             = try(each.value.create, var.defaults.create, true)
   create_certificate                                 = try(each.value.create_certificate, var.defaults.create_certificate, true)
   create_domain_name                                 = try(each.value.create_domain_name, var.defaults.create_domain_name, true)