fix: prevent lambda IAM policies from detaching when orders are swapped

Author: tammyisacoder

iam.tf

@@ -331,10 +331,10 @@ resource "aws_iam_role_policy_attachment" "additional_one" {
 ######################################
 
 resource "aws_iam_role_policy_attachment" "additional_many" {
-  count = local.create_role && var.attach_policies ? var.number_of_policies : 0
+  for_each = { for k, v in toset(var.policies) : k => v if local.create_role && var.attach_policies && var.number_of_policies > 0 }
 
   role       = aws_iam_role.lambda[0].name
-  policy_arn = var.policies[count.index]
+  policy_arn = each.value
 }
 
 ###############################