fix: ensure log group name is null when logging to CloudWatch is disabled to avoid error

bryantbiggs · bryantbiggs · commit bd485d047bab · 2021-12-22T10:35:22.000-05:00
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/antonbabenko/pre-commit-terraform
-    rev: v1.56.0
+    rev: v1.62.2
     hooks:
       - id: terraform_fmt
       - id: terraform_validate
diff --git a/main.tf b/main.tf
@@ -72,7 +72,7 @@ resource "aws_msk_cluster" "this" {
     broker_logs {
       cloudwatch_logs {
         enabled   = var.cloudwatch_logs_enabled
-        log_group = local.cloudwatch_log_group
+        log_group = var.cloudwatch_logs_enabled ? local.cloudwatch_log_group : null
       }
       firehose {
         enabled         = var.firehose_logs_enabled

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ resource "aws_msk_cluster" "this" {`
`72`	`72`	`broker_logs {`
`73`	`73`	`cloudwatch_logs {`
`74`	`74`	`enabled = var.cloudwatch_logs_enabled`
`75`		`- log_group = local.cloudwatch_log_group`
	`75`	`+ log_group = var.cloudwatch_logs_enabled ? local.cloudwatch_log_group : null`
`76`	`76`	`}`
`77`	`77`	`firehose {`
`78`	`78`	`enabled = var.firehose_logs_enabled`