Skip to content

Commit 8aa0a9a

Browse files
RupertExactantonbabenko
authored andcommitted
add vars for custom subnet and route table names (#168)
* add vars for custom subnet and route table names * revert db suffix to "db"
1 parent d722430 commit 8aa0a9a

File tree

2 files changed

+35
-10
lines changed

2 files changed

+35
-10
lines changed

main.tf

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ resource "aws_route_table" "public" {
7777

7878
vpc_id = "${local.vpc_id}"
7979

80-
tags = "${merge(map("Name", format("%s-public", var.name)), var.public_route_table_tags, var.tags)}"
80+
tags = "${merge(map("Name", format("%s-${var.public_subnet_suffix}", var.name)), var.public_route_table_tags, var.tags)}"
8181
}
8282

8383
resource "aws_route" "public_internet_gateway" {
@@ -101,7 +101,7 @@ resource "aws_route_table" "private" {
101101

102102
vpc_id = "${local.vpc_id}"
103103

104-
tags = "${merge(map("Name", (var.single_nat_gateway ? "${var.name}-private" : format("%s-private-%s", var.name, element(var.azs, count.index)))), var.private_route_table_tags, var.tags)}"
104+
tags = "${merge(map("Name", (var.single_nat_gateway ? "${var.name}-${var.private_subnet_suffix}" : format("%s-${var.private_subnet_suffix}-%s", var.name, element(var.azs, count.index)))), var.private_route_table_tags, var.tags)}"
105105

106106
lifecycle {
107107
# When attaching VPN gateways it is common to define aws_vpn_gateway_route_propagation
@@ -118,7 +118,7 @@ resource "aws_route_table" "database" {
118118

119119
vpc_id = "${local.vpc_id}"
120120

121-
tags = "${merge(var.tags, var.database_route_table_tags, map("Name", "${var.name}-database"))}"
121+
tags = "${merge(var.tags, var.database_route_table_tags, map("Name", "${var.name}-${var.database_subnet_suffix}"))}"
122122
}
123123

124124
#################
@@ -129,7 +129,7 @@ resource "aws_route_table" "redshift" {
129129

130130
vpc_id = "${local.vpc_id}"
131131

132-
tags = "${merge(var.tags, var.redshift_route_table_tags, map("Name", "${var.name}-redshift"))}"
132+
tags = "${merge(var.tags, var.redshift_route_table_tags, map("Name", "${var.name}-${var.redshift_subnet_suffix}"))}"
133133
}
134134

135135
#################
@@ -140,7 +140,7 @@ resource "aws_route_table" "elasticache" {
140140

141141
vpc_id = "${local.vpc_id}"
142142

143-
tags = "${merge(var.tags, var.elasticache_route_table_tags, map("Name", "${var.name}-elasticache"))}"
143+
tags = "${merge(var.tags, var.elasticache_route_table_tags, map("Name", "${var.name}-${var.elasticache_subnet_suffix}"))}"
144144
}
145145

146146
#################
@@ -165,7 +165,7 @@ resource "aws_subnet" "public" {
165165
availability_zone = "${element(var.azs, count.index)}"
166166
map_public_ip_on_launch = "${var.map_public_ip_on_launch}"
167167

168-
tags = "${merge(map("Name", format("%s-public-%s", var.name, element(var.azs, count.index))), var.public_subnet_tags, var.tags)}"
168+
tags = "${merge(map("Name", format("%s-${var.public_subnet_suffix}-%s", var.name, element(var.azs, count.index))), var.public_subnet_tags, var.tags)}"
169169
}
170170

171171
#################
@@ -178,7 +178,7 @@ resource "aws_subnet" "private" {
178178
cidr_block = "${var.private_subnets[count.index]}"
179179
availability_zone = "${element(var.azs, count.index)}"
180180

181-
tags = "${merge(map("Name", format("%s-private-%s", var.name, element(var.azs, count.index))), var.private_subnet_tags, var.tags)}"
181+
tags = "${merge(map("Name", format("%s-${var.private_subnet_suffix}-%s", var.name, element(var.azs, count.index))), var.private_subnet_tags, var.tags)}"
182182
}
183183

184184
##################
@@ -191,7 +191,7 @@ resource "aws_subnet" "database" {
191191
cidr_block = "${var.database_subnets[count.index]}"
192192
availability_zone = "${element(var.azs, count.index)}"
193193

194-
tags = "${merge(map("Name", format("%s-db-%s", var.name, element(var.azs, count.index))), var.database_subnet_tags, var.tags)}"
194+
tags = "${merge(map("Name", format("%s-${var.database_subnet_suffix}-%s", var.name, element(var.azs, count.index))), var.database_subnet_tags, var.tags)}"
195195
}
196196

197197
resource "aws_db_subnet_group" "database" {
@@ -214,7 +214,7 @@ resource "aws_subnet" "redshift" {
214214
cidr_block = "${var.redshift_subnets[count.index]}"
215215
availability_zone = "${element(var.azs, count.index)}"
216216

217-
tags = "${merge(map("Name", format("%s-redshift-%s", var.name, element(var.azs, count.index))), var.redshift_subnet_tags, var.tags)}"
217+
tags = "${merge(map("Name", format("%s-${var.redshift_subnet_suffix}-%s", var.name, element(var.azs, count.index))), var.redshift_subnet_tags, var.tags)}"
218218
}
219219

220220
resource "aws_redshift_subnet_group" "redshift" {
@@ -237,7 +237,7 @@ resource "aws_subnet" "elasticache" {
237237
cidr_block = "${var.elasticache_subnets[count.index]}"
238238
availability_zone = "${element(var.azs, count.index)}"
239239

240-
tags = "${merge(map("Name", format("%s-elasticache-%s", var.name, element(var.azs, count.index))), var.elasticache_subnet_tags, var.tags)}"
240+
tags = "${merge(map("Name", format("%s-${var.elasticache_subnet_suffix}-%s", var.name, element(var.azs, count.index))), var.elasticache_subnet_tags, var.tags)}"
241241
}
242242

243243
resource "aws_elasticache_subnet_group" "elasticache" {

variables.tf

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,31 @@ variable "instance_tenancy" {
2828
default = "default"
2929
}
3030

31+
variable "public_subnet_suffix" {
32+
description = "Suffix to append to public subnets name"
33+
default = "public"
34+
}
35+
36+
variable "private_subnet_suffix" {
37+
description = "Suffix to append to private subnets name"
38+
default = "private"
39+
}
40+
41+
variable "database_subnet_suffix" {
42+
description = "Suffix to append to database subnets name"
43+
default = "db"
44+
}
45+
46+
variable "redshift_subnet_suffix" {
47+
description = "Suffix to append to redshift subnets name"
48+
default = "redshift"
49+
}
50+
51+
variable "elasticache_subnet_suffix" {
52+
description = "Suffix to append to elasticache subnets name"
53+
default = "elasticache"
54+
}
55+
3156
variable "public_subnets" {
3257
description = "A list of public subnets inside the VPC"
3358
default = []

0 commit comments

Comments
 (0)