Skip to content

Commit cffc6ea

Browse files
committed
Resolved conflicts after merge
1 parent b4aa52c commit cffc6ea

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

README.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,11 +170,7 @@ Sometimes it is handy to have public access to RDS instances (it is not recommen
170170
Sometimes it is handy to have public access to Redshift clusters (for example if you need to access it by Kinesis - VPC endpoint for Kinesis is not yet supported by Redshift) by specifying these arguments:
171171

172172
```hcl
173-
<<<<<<< HEAD
174-
enable_public_redshift = true # <= Default it will be placed into private subnet route table
175-
=======
176173
enable_public_redshift = true # <= By default Redshift subnets will be associated with the private route table
177-
>>>>>>> Redshift public subnets (#222)
178174
```
179175

180176
## Terraform version
@@ -284,7 +280,6 @@ Terraform version 0.10.3 or newer is required for this module to work.
284280
| redshift\_subnet\_suffix | Suffix to append to redshift subnets name | string | `"redshift"` | no |
285281
| redshift\_subnet\_tags | Additional tags for the redshift subnets | map | `{}` | no |
286282
| redshift\_subnets | A list of redshift subnets | list | `[]` | no |
287-
| enable\_public\_redshift | Should be true if you want Redshift cluster to be placed into public subnet route table | string | `"false"` | no |
288283
| reuse\_nat\_ips | Should be true if you don't want EIPs to be created for your NAT Gateways and will instead pass them in via the 'external_nat_ip_ids' variable | string | `"false"` | no |
289284
| secondary\_cidr\_blocks | List of secondary CIDR blocks to associate with the VPC to extend the IP Address pool | list | `[]` | no |
290285
| single\_nat\_gateway | Should be true if you want to provision a single shared NAT Gateway across all of your private networks | string | `"false"` | no |

main.tf

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -569,22 +569,14 @@ resource "aws_route_table_association" "database" {
569569
}
570570

571571
resource "aws_route_table_association" "redshift" {
572-
<<<<<<< HEAD
573-
count = "${var.enable_public_redshift == false && var.create_vpc && length(var.redshift_subnets) > 0 ? length(var.redshift_subnets) : 0}"
574-
=======
575572
count = "${var.create_vpc && length(var.redshift_subnets) > 0 && !var.enable_public_redshift ? length(var.redshift_subnets) : 0}"
576-
>>>>>>> Redshift public subnets (#222)
577573

578574
subnet_id = "${element(aws_subnet.redshift.*.id, count.index)}"
579575
route_table_id = "${element(coalescelist(aws_route_table.redshift.*.id, aws_route_table.private.*.id), (var.single_nat_gateway || var.create_redshift_subnet_route_table ? 0 : count.index))}"
580576
}
581577

582578
resource "aws_route_table_association" "redshift_public" {
583-
<<<<<<< HEAD
584-
count = "${var.enable_public_redshift && var.create_vpc && length(var.redshift_subnets) > 0 ? length(var.redshift_subnets) : 0}"
585-
=======
586579
count = "${var.create_vpc && length(var.redshift_subnets) > 0 && var.enable_public_redshift ? length(var.redshift_subnets) : 0}"
587-
>>>>>>> Redshift public subnets (#222)
588580

589581
subnet_id = "${element(aws_subnet.redshift.*.id, count.index)}"
590582
route_table_id = "${element(coalescelist(aws_route_table.redshift.*.id, aws_route_table.public.*.id), (var.single_nat_gateway || var.create_redshift_subnet_route_table ? 0 : count.index))}"

0 commit comments

Comments
 (0)