precommit no verify - broken ipam example

Author: drewmullen

examples/ipam-vpc/main.tf

@@ -35,31 +35,58 @@ module "no_ipam_vpc_example" {
   cidr   = "172.2.0.32/28"
 }
 
-module "ipv4_ipam_explicit_cidr_vpc" {
-  source            = "../.."
-  name              = "ipv4-explicit-cidr-${local.name}"
-  ipv4_ipam_pool_id = aws_vpc_ipam_pool.ipv4_example.id
-  cidr              = "172.2.0.32/28"
+data "aws_vpc_ipam_preview_next_cidr" "previewed_cidr" {
+  ipam_pool_id   = aws_vpc_ipam_pool.ipv4_example.id
+  netmask_length = 24
+
   depends_on = [
     aws_vpc_ipam_pool_cidr.ipv4_example
   ]
 }
 
-module "ipv4_ipam_explicit_netmask_vpc" {
-  source              = "../.."
-  name                = "ipv4-explicit-netmask-${local.name}"
-  ipv4_ipam_pool_id   = aws_vpc_ipam_pool.ipv4_example.id
-  ipv4_netmask_length = 28
-  depends_on = [
-    aws_vpc_ipam_pool_cidr.ipv4_example
-  ]
+locals {
+  partition = cidrsubnets(data.aws_vpc_ipam_preview_next_cidr.previewed_cidr.cidr, 2, 2)
+  private_subnets = cidrsubnets(local.partition[0], 2, 2)
+  public_subnets = cidrsubnets(local.partition[1], 2, 2)
 }
 
-module "ipv4_ipam_default_netmask_vpc" {
+module "ipv4_ipam_calculate_subnets" {
   source            = "../.."
-  name              = "ipv4-default-netmask-${local.name}"
+  name              = "ipv4-calculated-subnets-${local.name}"
   ipv4_ipam_pool_id = aws_vpc_ipam_pool.ipv4_example.id
+  cidr              = data.aws_vpc_ipam_preview_next_cidr.previewed_cidr.cidr
+  private_subnets   = local.private_subnets
+  public_subnets    = local.public_subnets
   depends_on = [
     aws_vpc_ipam_pool_cidr.ipv4_example
   ]
 }
+
+# module "ipv4_ipam_explicit_cidr_vpc" {
+#   source            = "../.."
+#   name              = "ipv4-explicit-cidr-${local.name}"
+#   ipv4_ipam_pool_id = aws_vpc_ipam_pool.ipv4_example.id
+#   cidr              = "172.2.0.32/28"
+#   depends_on = [
+#     aws_vpc_ipam_pool_cidr.ipv4_example
+#   ]
+# }
+
+# module "ipv4_ipam_explicit_netmask_vpc" {
+#   source              = "../.."
+#   name                = "ipv4-explicit-netmask-${local.name}"
+#   ipv4_ipam_pool_id   = aws_vpc_ipam_pool.ipv4_example.id
+#   ipv4_netmask_length = 28
+#   depends_on = [
+#     aws_vpc_ipam_pool_cidr.ipv4_example
+#   ]
+# }
+
+# module "ipv4_ipam_default_netmask_vpc" {
+#   source            = "../.."
+#   name              = "ipv4-default-netmask-${local.name}"
+#   ipv4_ipam_pool_id = aws_vpc_ipam_pool.ipv4_example.id
+#   depends_on = [
+#     aws_vpc_ipam_pool_cidr.ipv4_example
+#   ]
+# }

examples/ipam-vpc/versions.tf

@@ -4,7 +4,7 @@ terraform {
   required_providers {
     aws = {
       source  = "hashicorp/aws"
-      version = ">= 3.68"
+      version = ">= 3.73"
     }
   }
 }

main.tf

@@ -25,7 +25,7 @@ locals {
 resource "aws_vpc" "this" {
   count = var.create_vpc ? 1 : 0
 
-  cidr_block          = var.ipv4_ipam_pool_id != null ? null : var.cidr
+  cidr_block          = var.cidr
   ipv4_ipam_pool_id   = var.ipv4_ipam_pool_id
   ipv4_netmask_length = var.ipv4_netmask_length
 

variables.tf

@@ -13,7 +13,7 @@ variable "name" {
 variable "cidr" {
   description = "(Optional) The IPv4 CIDR block for the VPC. CIDR can be explicitly set or it can be derived from IPAM using `ipv4_netmask_length` & `ipv4_ipam_pool_id`"
   type        = string
-  default     = "0.0.0.0/0"
+  default     = null
 }
 
 variable "enable_ipv6" {

versions.tf

@@ -4,7 +4,7 @@ terraform {
   required_providers {
     aws = {
       source  = "hashicorp/aws"
-      version = ">= 3.68"
+      version = ">= 3.73"
     }
   }
 }