Skip to content

Commit 17c5ab3

Browse files
committed
Start drafting the upgrade guide for v5.0
1 parent ed58124 commit 17c5ab3

File tree

2 files changed

+30
-0
lines changed

2 files changed

+30
-0
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77
Extending the adopted spec, each change should have a link to its corresponding pull request appended.
88

99
## [Unreleased]
10+
11+
## [v5.0.0] - 2019-XX-XX
12+
v5.0.0 is a backwards-incompatible release. Please see the [upgrading guide](./docs/upgrading_to_v5.0.md).
13+
1014
### Added
1115

1216
* Support for Intranode Visbiility (IV) and Veritical Pod Autoscaling (VPA) beta features [#216]

docs/upgrading_to_v5.0.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# Upgrading to v5.0
2+
3+
The v5.0 release of *kubernetes-engine* is a backwards incompatible
4+
release.
5+
6+
## Migration Instructions
7+
8+
### Service Account creation
9+
10+
Previously, if you explicitly specified a Service Account using the `service_account` variable on the module this was sufficient to force that Service Account to be used.
11+
12+
Now, an additional `create_service_account` has been added with a default value of `true`. If you would like to use an explicitly created Service Account from outside the module, you will need to set `create_service_account` to `false` (in addition to passing in the Service Account email).
13+
14+
No action is needed if you use the module's default service account.
15+
16+
```diff
17+
module "kubernetes_engine_private_cluster" {
18+
source = "terraform-google-modules/kubernetes-engine/google"
19+
- version = "~> 4.0"
20+
+ version = "~> 5.0"
21+
22+
service_account = "[email protected]"
23+
+ create_service_account = true
24+
# ...
25+
}
26+
```

0 commit comments

Comments
 (0)