Skip to content

Commit 21abdc2

Browse files
coryodanielaaron-lane
authored andcommitted
Added add'l describe block, quoted bools
1 parent cb80f68 commit 21abdc2

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

test/integration/disable_client_cert/controls/gcloud.rb

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,15 @@
4242
expect(data['masterAuth']['clientCertificate']).to be_nil
4343
end
4444

45-
it "does not have a basic auth enabled" do
46-
expect(data['masterAuth']['username']).to be_nil
47-
expect(data['masterAuth']['password']).to be_nil
45+
describe "does not have a basic auth enabled" do
46+
it "username is nil" do
47+
expect(data['masterAuth']['username']).to be_nil
48+
end
49+
50+
it "password is nil" do
51+
expect(data['masterAuth']['password']).to be_nil
52+
end
4853
end
4954
end
5055
end
51-
end
56+
end

variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ variable "service_account" {
219219

220220
variable "enable_basic_auth" {
221221
description = "Basic authentication allows a user to authenticate to the cluster with a username and password. To maximize the security of your cluster, disable this option. Basic authentication is not recommended because it provides no confidentiality protection for transmitted credentials"
222-
default = true
222+
default = "true"
223223
}
224224

225225
variable "basic_auth_username" {
@@ -234,5 +234,5 @@ variable "basic_auth_password" {
234234

235235
variable "issue_client_certificate" {
236236
description = "Issues a client certificate to authenticate to the cluster endpoint. To maximize the security of your cluster, leave this option disabled. Client certificates don't automatically rotate and aren't easily revocable. WARNING: changing this after cluster creation is destructive!"
237-
default = false
237+
default = "false"
238238
}

0 commit comments

Comments
 (0)