Skip to content

Commit 3f27bc2

Browse files
authored
chore: fix CI test sequencing and machine type (#1735)
1 parent b4ccabe commit 3f27bc2

File tree

4 files changed

+17
-19
lines changed

4 files changed

+17
-19
lines changed

build/int.cloudbuild.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ steps:
103103
args: ['/bin/bash', '-c', 'cft test run TestSimpleRegional --stage verify --verbose']
104104
- id: destroy simple-regional-local
105105
waitFor:
106-
- apply simple-regional-local
106+
- verify simple-regional-local
107107
name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS'
108108
args: ['/bin/bash', '-c', 'cft test run TestSimpleRegional --stage teardown --verbose']
109109
- id: init simple-regional-private-local
@@ -443,7 +443,7 @@ steps:
443443
args: ['/bin/bash', '-c', 'cft test run TestSimpleAutopilotPrivate --stage verify --verbose']
444444
- id: destroy simple-autopilot-private-local
445445
waitFor:
446-
- apply simple-autopilot-private-local
446+
- verify simple-autopilot-private-local
447447
name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS'
448448
args: ['/bin/bash', '-c', 'cft test run TestSimpleAutopilotPrivate --stage teardown --verbose']
449449
- id: init simple-autopilot-public-local

examples/node_pool/main.tf

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -50,18 +50,17 @@ module "gke" {
5050
auto_upgrade = true
5151
},
5252
{
53-
name = "pool-02"
54-
machine_type = "a2-highgpu-1g"
55-
min_count = 1
56-
max_count = 2
57-
local_ssd_count = 0
58-
disk_size_gb = 30
59-
disk_type = "pd-standard"
60-
accelerator_count = 1
61-
accelerator_type = "nvidia-tesla-a100"
62-
gpu_partition_size = "1g.5gb"
63-
auto_repair = false
64-
service_account = var.compute_engine_service_account
53+
name = "pool-02"
54+
machine_type = "n1-standard-2"
55+
min_count = 1
56+
max_count = 2
57+
local_ssd_count = 0
58+
disk_size_gb = 30
59+
disk_type = "pd-standard"
60+
accelerator_count = 1
61+
accelerator_type = "nvidia-tesla-p4"
62+
auto_repair = false
63+
service_account = var.compute_engine_service_account
6564
},
6665
{
6766
name = "pool-03"

test/fixtures/node_pool/example.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ module "example" {
2020
project_id = var.project_ids[0]
2121
cluster_name_suffix = "-${random_string.suffix.result}"
2222
region = "europe-west4"
23-
zones = ["europe-west4-a"]
23+
zones = ["europe-west4-b"]
2424
network = google_compute_network.main.name
2525
subnetwork = google_compute_subnetwork.main.name
2626
ip_range_pods = google_compute_subnetwork.main.secondary_ip_range[0].range_name

test/integration/node_pool/controls/gcloud.rb

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
cluster_name = attribute('cluster_name')
1818

1919
expected_accelerators_count = "1"
20-
expected_accelerators_type = "nvidia-tesla-a100"
20+
expected_accelerators_type = "nvidia-tesla-p4"
2121

2222
control "gcloud" do
2323
title "Google Compute Engine GKE configuration"
@@ -218,7 +218,7 @@
218218
including(
219219
"name" => "pool-02",
220220
"config" => including(
221-
"machineType" => "a2-highgpu-1g",
221+
"machineType" => "n1-standard-2",
222222
),
223223
)
224224
)
@@ -263,8 +263,7 @@
263263
"name" => "pool-02",
264264
"config" => including(
265265
"accelerators" => [{"acceleratorCount" => expected_accelerators_count,
266-
"acceleratorType" => expected_accelerators_type,
267-
"gpuPartitionSize" => "1g.5gb"}],
266+
"acceleratorType" => expected_accelerators_type}],
268267
),
269268
)
270269
)

0 commit comments

Comments
 (0)