Skip to content

Commit 46bc9c4

Browse files
committed
Fix handling of credentials file
1 parent 9ea4516 commit 46bc9c4

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

Makefile

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
SHELL := /usr/bin/env bash
1717

1818
# Docker build config variables
19+
CREDENTIALS_PATH ?= /cft/workdir/credentials.json
1920
DOCKER_ORG := gcr.io/cloud-foundation-cicd
2021
DOCKER_TAG_BASE_KITCHEN_TERRAFORM ?= 0.11.10_216.0.0_1.19.1_0.1.10
2122
DOCKER_REPO_BASE_KITCHEN_TERRAFORM := ${DOCKER_ORG}/cft/kitchen-terraform:${DOCKER_TAG_BASE_KITCHEN_TERRAFORM}
@@ -106,34 +107,44 @@ docker_push_kitchen_terraform:
106107
.PHONY: docker_run
107108
docker_run:
108109
docker run --rm -it \
110+
-e CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE=${CREDENTIALS_PATH} \
111+
-e GOOGLE_APPLICATION_CREDENTIALS=${CREDENTIALS_PATH} \
109112
-v $(CURDIR):/cft/workdir \
110113
${DOCKER_IMAGE_KITCHEN_TERRAFORM}:${DOCKER_TAG_KITCHEN_TERRAFORM} \
111114
/bin/bash
112115

113116
.PHONY: docker_create
114117
docker_create: docker_build_kitchen_terraform
115118
docker run --rm -it \
119+
-e CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE=${CREDENTIALS_PATH} \
120+
-e GOOGLE_APPLICATION_CREDENTIALS=${CREDENTIALS_PATH} \
116121
-v $(CURDIR):/cft/workdir \
117122
${DOCKER_IMAGE_KITCHEN_TERRAFORM}:${DOCKER_TAG_KITCHEN_TERRAFORM} \
118123
/bin/bash -c "kitchen create"
119124

120125
.PHONY: docker_converge
121126
docker_converge:
122127
docker run --rm -it \
128+
-e CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE=${CREDENTIALS_PATH} \
129+
-e GOOGLE_APPLICATION_CREDENTIALS=${CREDENTIALS_PATH} \
123130
-v $(CURDIR):/cft/workdir \
124131
${DOCKER_IMAGE_KITCHEN_TERRAFORM}:${DOCKER_TAG_KITCHEN_TERRAFORM} \
125132
/bin/bash -c "kitchen converge && kitchen converge"
126133

127134
.PHONY: docker_verify
128135
docker_verify:
129136
docker run --rm -it \
137+
-e CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE=${CREDENTIALS_PATH} \
138+
-e GOOGLE_APPLICATION_CREDENTIALS=${CREDENTIALS_PATH} \
130139
-v $(CURDIR):/cft/workdir \
131140
${DOCKER_IMAGE_KITCHEN_TERRAFORM}:${DOCKER_TAG_KITCHEN_TERRAFORM} \
132141
/bin/bash -c "kitchen verify"
133142

134143
.PHONY: docker_destroy
135144
docker_destroy:
136145
docker run --rm -it \
146+
-e CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE=${CREDENTIALS_PATH} \
147+
-e GOOGLE_APPLICATION_CREDENTIALS=${CREDENTIALS_PATH} \
137148
-v $(CURDIR):/cft/workdir \
138149
${DOCKER_IMAGE_KITCHEN_TERRAFORM}:${DOCKER_TAG_KITCHEN_TERRAFORM} \
139150
/bin/bash -c "kitchen destroy"

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,8 @@ The test-kitchen instances in `test/fixtures/` wrap identically-named examples i
230230
3. Build the Docker containers for testing:
231231

232232
```
233-
CREDENTIALS_FILE="credentials.json" make docker_build_terraform
234-
CREDENTIALS_FILE="credentials.json" make docker_build_kitchen_terraform
233+
make docker_build_terraform
234+
make docker_build_kitchen_terraform
235235
```
236236
4. Run the testing container in interactive mode:
237237

@@ -247,7 +247,7 @@ The test-kitchen instances in `test/fixtures/` wrap identically-named examples i
247247
3. `kitchen verify` tests the created infrastructure. Run `kitchen verify <INSTANCE_NAME>` to run a specific test case.
248248
4. `kitchen destroy` tears down the underlying resources created by `kitchen converge`. Run `kitchen destroy <INSTANCE_NAME>` to tear down resources for a specific test case.
249249

250-
Alternatively, you can simply run `CREDENTIALS_FILE="credentials.json" make test_integration_docker` to run all the test steps non-interactively.
250+
Alternatively, you can simply run `make test_integration_docker` to run all the test steps non-interactively.
251251

252252
#### Test configuration
253253

0 commit comments

Comments
 (0)