Skip to content

Commit 9e92318

Browse files
authored
fix: various fix to address CI issues (#1248)
fix: add output "service_account" to simple_zonal chore: convert remaining examples/CI to COS_CONTAINERD
1 parent 9359961 commit 9e92318

File tree

11 files changed

+8
-9
lines changed

11 files changed

+8
-9
lines changed

examples/node_pool/main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ module "gke" {
6060
accelerator_count = 1
6161
accelerator_type = "nvidia-tesla-a100"
6262
gpu_partition_size = "1g.5gb"
63-
image_type = "COS"
6463
auto_repair = false
6564
service_account = var.compute_engine_service_account
6665
},

examples/node_pool_update_variant/main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ module "gke" {
7373
disk_type = "pd-standard"
7474
accelerator_count = 1
7575
accelerator_type = "nvidia-tesla-p4"
76-
image_type = "COS"
7776
auto_repair = false
7877
service_account = var.compute_engine_service_account
7978
},

examples/node_pool_update_variant_beta/main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ module "gke" {
7878
disk_type = "pd-standard"
7979
accelerator_count = 1
8080
accelerator_type = "nvidia-tesla-p4"
81-
image_type = "COS"
8281
auto_repair = false
8382
service_account = var.compute_engine_service_account
8483
},

examples/node_pool_update_variant_public_beta/main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ module "gke" {
7474
disk_type = "pd-standard"
7575
accelerator_count = 1
7676
accelerator_type = "nvidia-tesla-p4"
77-
image_type = "COS"
7877
auto_repair = false
7978
service_account = var.compute_engine_service_account
8079
},

examples/regional_private_node_pool_oauth_scopes/main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ module "gke" {
4848
max_count = 1
4949
disk_size_gb = 100
5050
disk_type = "pd-ssd"
51-
image_type = "COS"
5251
auto_repair = true
5352
auto_upgrade = false
5453
preemptible = false

examples/safer_cluster_iap_bastion/apis.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ module "enabled_google_apis" {
2222
disable_services_on_destroy = false
2323

2424
activate_apis = [
25+
"serviceusage.googleapis.com",
2526
"iam.googleapis.com",
2627
"compute.googleapis.com",
2728
"logging.googleapis.com",

examples/simple_regional_private/main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ module "gke" {
5858
local_ssd_count = 0
5959
disk_size_gb = 100
6060
disk_type = "pd-standard"
61-
image_type = "COS"
6261
auto_repair = true
6362
auto_upgrade = true
6463
service_account = var.compute_engine_service_account

test/fixtures/sandbox_enabled/example.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ module "example" {
3333
node_pools = [
3434
{
3535
name = "default-node-pool"
36-
image_type = "COS_CONTAINERD"
3736
machine_type = "n1-standard-2"
3837
},
3938
]

test/fixtures/simple_zonal/outputs.tf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,3 +51,8 @@ output "ca_certificate" {
5151
value = module.example.ca_certificate
5252
sensitive = true
5353
}
54+
55+
output "service_account" {
56+
description = "The service account to default running nodes as if not overridden in `node_pools`."
57+
value = module.example.service_account
58+
}

test/integration/node_pool/controls/gcloud.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@
297297
including(
298298
"name" => "pool-02",
299299
"config" => including(
300-
"imageType" => "COS",
300+
"imageType" => "COS_CONTAINERD",
301301
),
302302
)
303303
)

test/integration/simple_autopilot_private/controls/gcloud.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232

3333
describe "cluster" do
3434
it "is running" do
35-
expect(data['status']).to eq 'RUNNING'
35+
expect(data['status']).to eq('RUNNING').or eq('RECONCILING')
3636
end
3737

3838
it "is autopilot" do

0 commit comments

Comments
 (0)