Skip to content

Commit c260523

Browse files
committed
add missing dns_cache output in non beta
Signed-off-by: drfaust92 <[email protected]>
1 parent 19e9c0d commit c260523

File tree

23 files changed

+54
-43
lines changed

23 files changed

+54
-43
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ module "gke" {
5050
network_policy = false
5151
horizontal_pod_autoscaling = true
5252
filestore_csi_driver = false
53+
dns_cache = false
5354
5455
node_pools = [
5556
{
@@ -239,6 +240,7 @@ Then perform the following commands on the root folder:
239240
|------|-------------|
240241
| ca\_certificate | Cluster ca certificate (base64 encoded) |
241242
| cluster\_id | Cluster ID |
243+
| dns\_cache\_enabled | Whether DNS Cache enabled |
242244
| endpoint | Cluster endpoint |
243245
| fleet\_membership | Fleet membership (if registered) |
244246
| gateway\_api\_channel | The gateway api channel of this cluster. |

autogen/main/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ module "gke" {
9090
{% if beta_cluster and autopilot_cluster != true %}
9191
istio = true
9292
cloudrun = true
93-
dns_cache = false
9493
{% endif %}
94+
dns_cache = false
9595
9696
{% if autopilot_cluster != true %}
9797
node_pools = [

autogen/main/main.tf.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ locals {
231231
{% if beta_cluster %}
232232
# BETA features
233233
cluster_istio_enabled = ! local.cluster_output_istio_disabled
234-
cluster_dns_cache_enabled = var.dns_cache
235234
{% if autopilot_cluster != true %}
236235
cluster_telemetry_type_is_set = var.cluster_telemetry_type != null
237236
{% endif %}
@@ -241,6 +240,7 @@ locals {
241240
# /BETA features
242241
{% endif %}
243242

243+
cluster_dns_cache_enabled = var.dns_cache
244244
cluster_maintenance_window_is_recurring = var.maintenance_recurrence != "" && var.maintenance_end_time != "" ? [1] : []
245245
cluster_maintenance_window_is_daily = length(local.cluster_maintenance_window_is_recurring) > 0 ? [] : [1]
246246
}

autogen/main/outputs.tf.tmpl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,11 @@ output "peering_name" {
198198
value = local.cluster_peering_name
199199
}
200200
{% endif %}
201+
202+
output "dns_cache_enabled" {
203+
description = "Whether DNS Cache enabled"
204+
value = local.cluster_dns_cache_enabled
205+
}
201206
{% if beta_cluster %}
202207

203208
output "cloudrun_enabled" {
@@ -214,11 +219,6 @@ output "istio_enabled" {
214219
value = local.cluster_istio_enabled
215220
}
216221

217-
output "dns_cache_enabled" {
218-
description = "Whether DNS Cache enabled"
219-
value = local.cluster_dns_cache_enabled
220-
}
221-
222222
output "pod_security_policy_enabled" {
223223
description = "Whether pod security policy is enabled"
224224
value = local.cluster_pod_security_policy_enabled

main.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ locals {
170170
}] : []
171171

172172

173+
cluster_dns_cache_enabled = var.dns_cache
173174
cluster_maintenance_window_is_recurring = var.maintenance_recurrence != "" && var.maintenance_end_time != "" ? [1] : []
174175
cluster_maintenance_window_is_daily = length(local.cluster_maintenance_window_is_recurring) > 0 ? [] : [1]
175176
}

modules/beta-autopilot-private-cluster/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ module "gke" {
5454
enable_private_endpoint = true
5555
enable_private_nodes = true
5656
master_ipv4_cidr_block = "10.0.0.0/28"
57+
dns_cache = false
5758
5859
}
5960
```

modules/beta-autopilot-private-cluster/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,12 +127,12 @@ locals {
127127

128128
# BETA features
129129
cluster_istio_enabled = !local.cluster_output_istio_disabled
130-
cluster_dns_cache_enabled = var.dns_cache
131130
cluster_pod_security_policy_enabled = local.cluster_output_pod_security_policy_enabled
132131
cluster_intranode_visibility_enabled = local.cluster_output_intranode_visbility_enabled
133132

134133
# /BETA features
135134

135+
cluster_dns_cache_enabled = var.dns_cache
136136
cluster_maintenance_window_is_recurring = var.maintenance_recurrence != "" && var.maintenance_end_time != "" ? [1] : []
137137
cluster_maintenance_window_is_daily = length(local.cluster_maintenance_window_is_recurring) > 0 ? [] : [1]
138138
}

modules/beta-autopilot-private-cluster/outputs.tf

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,11 @@ output "peering_name" {
159159
value = local.cluster_peering_name
160160
}
161161

162+
output "dns_cache_enabled" {
163+
description = "Whether DNS Cache enabled"
164+
value = local.cluster_dns_cache_enabled
165+
}
166+
162167
output "cloudrun_enabled" {
163168
description = "Whether CloudRun enabled"
164169
value = false
@@ -169,11 +174,6 @@ output "istio_enabled" {
169174
value = local.cluster_istio_enabled
170175
}
171176

172-
output "dns_cache_enabled" {
173-
description = "Whether DNS Cache enabled"
174-
value = local.cluster_dns_cache_enabled
175-
}
176-
177177
output "pod_security_policy_enabled" {
178178
description = "Whether pod security policy is enabled"
179179
value = local.cluster_pod_security_policy_enabled

modules/beta-autopilot-public-cluster/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ module "gke" {
4848
ip_range_services = "us-central1-01-gke-01-services"
4949
horizontal_pod_autoscaling = true
5050
filestore_csi_driver = false
51+
dns_cache = false
5152
5253
}
5354
```

modules/beta-autopilot-public-cluster/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,12 @@ locals {
126126

127127
# BETA features
128128
cluster_istio_enabled = !local.cluster_output_istio_disabled
129-
cluster_dns_cache_enabled = var.dns_cache
130129
cluster_pod_security_policy_enabled = local.cluster_output_pod_security_policy_enabled
131130
cluster_intranode_visibility_enabled = local.cluster_output_intranode_visbility_enabled
132131

133132
# /BETA features
134133

134+
cluster_dns_cache_enabled = var.dns_cache
135135
cluster_maintenance_window_is_recurring = var.maintenance_recurrence != "" && var.maintenance_end_time != "" ? [1] : []
136136
cluster_maintenance_window_is_daily = length(local.cluster_maintenance_window_is_recurring) > 0 ? [] : [1]
137137
}

modules/beta-autopilot-public-cluster/outputs.tf

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,11 @@ output "tpu_ipv4_cidr_block" {
149149

150150

151151

152+
output "dns_cache_enabled" {
153+
description = "Whether DNS Cache enabled"
154+
value = local.cluster_dns_cache_enabled
155+
}
156+
152157
output "cloudrun_enabled" {
153158
description = "Whether CloudRun enabled"
154159
value = false
@@ -159,11 +164,6 @@ output "istio_enabled" {
159164
value = local.cluster_istio_enabled
160165
}
161166

162-
output "dns_cache_enabled" {
163-
description = "Whether DNS Cache enabled"
164-
value = local.cluster_dns_cache_enabled
165-
}
166-
167167
output "pod_security_policy_enabled" {
168168
description = "Whether pod security policy is enabled"
169169
value = local.cluster_pod_security_policy_enabled

modules/beta-private-cluster-update-variant/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,13 +190,13 @@ locals {
190190

191191
# BETA features
192192
cluster_istio_enabled = !local.cluster_output_istio_disabled
193-
cluster_dns_cache_enabled = var.dns_cache
194193
cluster_telemetry_type_is_set = var.cluster_telemetry_type != null
195194
cluster_pod_security_policy_enabled = local.cluster_output_pod_security_policy_enabled
196195
cluster_intranode_visibility_enabled = local.cluster_output_intranode_visbility_enabled
197196

198197
# /BETA features
199198

199+
cluster_dns_cache_enabled = var.dns_cache
200200
cluster_maintenance_window_is_recurring = var.maintenance_recurrence != "" && var.maintenance_end_time != "" ? [1] : []
201201
cluster_maintenance_window_is_daily = length(local.cluster_maintenance_window_is_recurring) > 0 ? [] : [1]
202202
}

modules/beta-private-cluster-update-variant/outputs.tf

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,11 @@ output "peering_name" {
185185
value = local.cluster_peering_name
186186
}
187187

188+
output "dns_cache_enabled" {
189+
description = "Whether DNS Cache enabled"
190+
value = local.cluster_dns_cache_enabled
191+
}
192+
188193
output "cloudrun_enabled" {
189194
description = "Whether CloudRun enabled"
190195
value = local.cluster_cloudrun_enabled
@@ -195,11 +200,6 @@ output "istio_enabled" {
195200
value = local.cluster_istio_enabled
196201
}
197202

198-
output "dns_cache_enabled" {
199-
description = "Whether DNS Cache enabled"
200-
value = local.cluster_dns_cache_enabled
201-
}
202-
203203
output "pod_security_policy_enabled" {
204204
description = "Whether pod security policy is enabled"
205205
value = local.cluster_pod_security_policy_enabled

modules/beta-private-cluster/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,13 +190,13 @@ locals {
190190

191191
# BETA features
192192
cluster_istio_enabled = !local.cluster_output_istio_disabled
193-
cluster_dns_cache_enabled = var.dns_cache
194193
cluster_telemetry_type_is_set = var.cluster_telemetry_type != null
195194
cluster_pod_security_policy_enabled = local.cluster_output_pod_security_policy_enabled
196195
cluster_intranode_visibility_enabled = local.cluster_output_intranode_visbility_enabled
197196

198197
# /BETA features
199198

199+
cluster_dns_cache_enabled = var.dns_cache
200200
cluster_maintenance_window_is_recurring = var.maintenance_recurrence != "" && var.maintenance_end_time != "" ? [1] : []
201201
cluster_maintenance_window_is_daily = length(local.cluster_maintenance_window_is_recurring) > 0 ? [] : [1]
202202
}

modules/beta-private-cluster/outputs.tf

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,11 @@ output "peering_name" {
185185
value = local.cluster_peering_name
186186
}
187187

188+
output "dns_cache_enabled" {
189+
description = "Whether DNS Cache enabled"
190+
value = local.cluster_dns_cache_enabled
191+
}
192+
188193
output "cloudrun_enabled" {
189194
description = "Whether CloudRun enabled"
190195
value = local.cluster_cloudrun_enabled
@@ -195,11 +200,6 @@ output "istio_enabled" {
195200
value = local.cluster_istio_enabled
196201
}
197202

198-
output "dns_cache_enabled" {
199-
description = "Whether DNS Cache enabled"
200-
value = local.cluster_dns_cache_enabled
201-
}
202-
203203
output "pod_security_policy_enabled" {
204204
description = "Whether pod security policy is enabled"
205205
value = local.cluster_pod_security_policy_enabled

modules/beta-public-cluster-update-variant/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,13 +189,13 @@ locals {
189189

190190
# BETA features
191191
cluster_istio_enabled = !local.cluster_output_istio_disabled
192-
cluster_dns_cache_enabled = var.dns_cache
193192
cluster_telemetry_type_is_set = var.cluster_telemetry_type != null
194193
cluster_pod_security_policy_enabled = local.cluster_output_pod_security_policy_enabled
195194
cluster_intranode_visibility_enabled = local.cluster_output_intranode_visbility_enabled
196195

197196
# /BETA features
198197

198+
cluster_dns_cache_enabled = var.dns_cache
199199
cluster_maintenance_window_is_recurring = var.maintenance_recurrence != "" && var.maintenance_end_time != "" ? [1] : []
200200
cluster_maintenance_window_is_daily = length(local.cluster_maintenance_window_is_recurring) > 0 ? [] : [1]
201201
}

modules/beta-public-cluster-update-variant/outputs.tf

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,11 @@ output "mesh_certificates_config" {
175175
}
176176

177177

178+
output "dns_cache_enabled" {
179+
description = "Whether DNS Cache enabled"
180+
value = local.cluster_dns_cache_enabled
181+
}
182+
178183
output "cloudrun_enabled" {
179184
description = "Whether CloudRun enabled"
180185
value = local.cluster_cloudrun_enabled
@@ -185,11 +190,6 @@ output "istio_enabled" {
185190
value = local.cluster_istio_enabled
186191
}
187192

188-
output "dns_cache_enabled" {
189-
description = "Whether DNS Cache enabled"
190-
value = local.cluster_dns_cache_enabled
191-
}
192-
193193
output "pod_security_policy_enabled" {
194194
description = "Whether pod security policy is enabled"
195195
value = local.cluster_pod_security_policy_enabled

modules/beta-public-cluster/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,13 +189,13 @@ locals {
189189

190190
# BETA features
191191
cluster_istio_enabled = !local.cluster_output_istio_disabled
192-
cluster_dns_cache_enabled = var.dns_cache
193192
cluster_telemetry_type_is_set = var.cluster_telemetry_type != null
194193
cluster_pod_security_policy_enabled = local.cluster_output_pod_security_policy_enabled
195194
cluster_intranode_visibility_enabled = local.cluster_output_intranode_visbility_enabled
196195

197196
# /BETA features
198197

198+
cluster_dns_cache_enabled = var.dns_cache
199199
cluster_maintenance_window_is_recurring = var.maintenance_recurrence != "" && var.maintenance_end_time != "" ? [1] : []
200200
cluster_maintenance_window_is_daily = length(local.cluster_maintenance_window_is_recurring) > 0 ? [] : [1]
201201
}

modules/beta-public-cluster/outputs.tf

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,11 @@ output "mesh_certificates_config" {
175175
}
176176

177177

178+
output "dns_cache_enabled" {
179+
description = "Whether DNS Cache enabled"
180+
value = local.cluster_dns_cache_enabled
181+
}
182+
178183
output "cloudrun_enabled" {
179184
description = "Whether CloudRun enabled"
180185
value = local.cluster_cloudrun_enabled
@@ -185,11 +190,6 @@ output "istio_enabled" {
185190
value = local.cluster_istio_enabled
186191
}
187192

188-
output "dns_cache_enabled" {
189-
description = "Whether DNS Cache enabled"
190-
value = local.cluster_dns_cache_enabled
191-
}
192-
193193
output "pod_security_policy_enabled" {
194194
description = "Whether pod security policy is enabled"
195195
value = local.cluster_pod_security_policy_enabled

modules/private-cluster-update-variant/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ module "gke" {
7878
enable_private_endpoint = true
7979
enable_private_nodes = true
8080
master_ipv4_cidr_block = "10.0.0.0/28"
81+
dns_cache = false
8182
8283
node_pools = [
8384
{
@@ -272,6 +273,7 @@ Then perform the following commands on the root folder:
272273
|------|-------------|
273274
| ca\_certificate | Cluster ca certificate (base64 encoded) |
274275
| cluster\_id | Cluster ID |
276+
| dns\_cache\_enabled | Whether DNS Cache enabled |
275277
| endpoint | Cluster endpoint |
276278
| fleet\_membership | Fleet membership (if registered) |
277279
| gateway\_api\_channel | The gateway api channel of this cluster. |

modules/private-cluster-update-variant/main.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ locals {
171171
}] : []
172172

173173

174+
cluster_dns_cache_enabled = var.dns_cache
174175
cluster_maintenance_window_is_recurring = var.maintenance_recurrence != "" && var.maintenance_end_time != "" ? [1] : []
175176
cluster_maintenance_window_is_daily = length(local.cluster_maintenance_window_is_recurring) > 0 ? [] : [1]
176177
}

modules/private-cluster/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ module "gke" {
5656
enable_private_endpoint = true
5757
enable_private_nodes = true
5858
master_ipv4_cidr_block = "10.0.0.0/28"
59+
dns_cache = false
5960
6061
node_pools = [
6162
{
@@ -250,6 +251,7 @@ Then perform the following commands on the root folder:
250251
|------|-------------|
251252
| ca\_certificate | Cluster ca certificate (base64 encoded) |
252253
| cluster\_id | Cluster ID |
254+
| dns\_cache\_enabled | Whether DNS Cache enabled |
253255
| endpoint | Cluster endpoint |
254256
| fleet\_membership | Fleet membership (if registered) |
255257
| gateway\_api\_channel | The gateway api channel of this cluster. |

modules/private-cluster/main.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ locals {
171171
}] : []
172172

173173

174+
cluster_dns_cache_enabled = var.dns_cache
174175
cluster_maintenance_window_is_recurring = var.maintenance_recurrence != "" && var.maintenance_end_time != "" ? [1] : []
175176
cluster_maintenance_window_is_daily = length(local.cluster_maintenance_window_is_recurring) > 0 ? [] : [1]
176177
}

0 commit comments

Comments
 (0)