Skip to content

Commit e494973

Browse files
committed
Merge remote-tracking branch 'upstream/master' into OPS_31316_extend_for_ep
2 parents 775ef58 + f057964 commit e494973

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

README.md

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ module "gke" {
4040
auto_repair = true
4141
auto_upgrade = true
4242
service_account = "project-service-account@<PROJECT ID>.iam.gserviceaccount.com"
43+
preemptible = false
4344
},
4445
]
4546
@@ -87,6 +88,8 @@ Then perform the following commands on the root folder:
8788
- `terraform plan` to see the infrastructure plan
8889
- `terraform apply` to apply the infrastructure build
8990
- `terraform destroy` to destroy the built infrastructure
91+
92+
9093
[^]: (autogen_docs_start)
9194

9295

@@ -151,6 +154,17 @@ Then perform the following commands on the root folder:
151154
[^]: (autogen_docs_end)
152155

153156
## Requirements
157+
158+
Before this module can be used on a project, you must ensure that the following pre-requisites are fulfilled:
159+
160+
1. Terraform and kubectl are [installed](#software-dependencies) on the machine where Terraform is executed.
161+
2. The Service Account you execute the module with has the right [permissions](#iam-roles).
162+
3. The Compute Engine and Kubernetes Engine APIs are [active](#enable-apis) on the project you will launch the cluster in.
163+
4. If you are using a Shared VPC, the APIs must also be activated on the Shared VPC host project and your service account needs the proper permissions there.
164+
165+
The [project factory](https://github.com/terraform-google-modules/terraform-google-project-factory) can be used to provision projects with the correct APIs active and the necessary Shared VPC connections.
166+
167+
### Software Dependencies
154168
### Kubectl
155169
- [kubectl](https://github.com/kubernetes/kubernetes/releases) 1.9.x
156170
### Terraform plugins
@@ -160,12 +174,12 @@ Then perform the following commands on the root folder:
160174
### Configure a Service Account
161175
In order to execute this module you must have a Service Account with the following:
162176

163-
#### Roles
177+
#### IAM Roles
164178
The service account with the following roles:
165179
- roles/compute.viewer on the project
166180
- roles/container.clusterAdmin on the project
167181

168-
### Enable API's
182+
### Enable APIs
169183
In order to operate with the Service Account you must activate the following APIs on the project where the Service Account was created:
170184

171185
- Compute Engine API - compute.googleapis.com

cluster_zonal.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ resource "google_container_cluster" "zonal_primary" {
2424
project = "${var.project_id}"
2525

2626
zone = "${var.zones[0]}"
27-
additional_zones = "${slice(var.zones,1,length(var.zones))}"
27+
additional_zones = ["${slice(var.zones,1,length(var.zones))}"]
2828

2929
network = "${data.google_compute_network.gke_network.self_link}"
3030
subnetwork = "${data.google_compute_subnetwork.gke_subnetwork.self_link}"

0 commit comments

Comments
 (0)