Fix rule template for rule generator (#161)

Author: wata727

rules/provider.go

@@ -6,30 +6,26 @@ import (
 	"github.com/terraform-linters/tflint-ruleset-google/rules/magicmodules"
 )
 
-var rules = [][]tflint.Rule{
-	{
-		NewGoogleComposerEnvironmentInvalidMachineTypeRule(),
-		NewGoogleComputeInstanceInvalidMachineTypeRule(),
-		NewGoogleComputeReservationInvalidMachineTypeRule(),
-		NewGoogleComputeInstanceTemplateInvalidMachineTypeRule(),
-		NewGoogleContainerClusterInvalidMachineTypeRule(),
-		NewGoogleContainerNodePoolInvalidMachineTypeRule(),
-		NewGoogleDataflowJobInvalidMachineTypeRule(),
-		NewGoogleComputeResourcePolicyInvalidNameRule(),
-		NewGoogleProjectIamMemberInvalidMemberRule(),
-		NewGoogleProjectIamAuditConfigInvalidMemberRule(),
-		NewGoogleProjectIamBindingInvalidMemberRule(),
-		NewGoogleProjectIamPolicyInvalidMemberRule(),
-	},
-	magicmodules.Rules,
-	api.Rules,
+var manualRules = []tflint.Rule{
+	NewGoogleComposerEnvironmentInvalidMachineTypeRule(),
+	NewGoogleComputeInstanceInvalidMachineTypeRule(),
+	NewGoogleComputeReservationInvalidMachineTypeRule(),
+	NewGoogleComputeInstanceTemplateInvalidMachineTypeRule(),
+	NewGoogleContainerClusterInvalidMachineTypeRule(),
+	NewGoogleContainerNodePoolInvalidMachineTypeRule(),
+	NewGoogleDataflowJobInvalidMachineTypeRule(),
+	NewGoogleComputeResourcePolicyInvalidNameRule(),
+	NewGoogleProjectIamMemberInvalidMemberRule(),
+	NewGoogleProjectIamAuditConfigInvalidMemberRule(),
+	NewGoogleProjectIamBindingInvalidMemberRule(),
+	NewGoogleProjectIamPolicyInvalidMemberRule(),
 }
 
 // Rules is a list of all rules
 var Rules []tflint.Rule
 
 func init() {
-	for _, r := range rules {
-		Rules = append(Rules, r...)
-	}
+	Rules = append(Rules, manualRules...)
+	Rules = append(Rules, magicmodules.Rules...)
+	Rules = append(Rules, api.Rules...)
 }

rules/rule.go.tmpl

@@ -1,14 +1,16 @@
 package rules
 
 import (
-	hcl "github.com/hashicorp/hcl/v2"
+	"github.com/terraform-linters/tflint-plugin-sdk/hclext"
 	"github.com/terraform-linters/tflint-plugin-sdk/tflint"
 	"github.com/terraform-linters/tflint-ruleset-google/project"
 )
 
 // TODO: Write the rule's description here
 // {{ .RuleNameCC }}Rule checks ...
 type {{ .RuleNameCC }}Rule struct {
+	tflint.DefaultRule
+
 	resourceType  string
 	attributeName string
 }
@@ -34,7 +36,7 @@ func (r *{{ .RuleNameCC }}Rule) Enabled() bool {
 }
 
 // Severity returns the rule severity
-func (r *{{ .RuleNameCC }}Rule) Severity() string {
+func (r *{{ .RuleNameCC }}Rule) Severity() tflint.Severity {
 	// TODO: Determine the rule's severiry
 	return tflint.ERROR
 }
@@ -51,19 +53,38 @@ func (r *{{ .RuleNameCC }}Rule) Check(runner tflint.Runner) error {
 	// TODO: Write the implementation here. See this documentation for what tflint.Runner can do.
 	//       https://pkg.go.dev/github.com/terraform-linters/tflint-plugin-sdk/tflint#Runner
 
-	return runner.WalkResourceAttributes(r.resourceType, r.attributeName, func(attribute *hcl.Attribute) error {
+	resources, err := runner.GetResourceContent(r.resourceType, &hclext.BodySchema{
+		Attributes: []hclext.AttributeSchema{
+			{Name: r.attributeName},
+		},
+	}, nil)
+	if err != nil {
+		return err
+	}
+
+	for _, resource := range resources.Blocks {
+		attribute, exists := resource.Body.Attributes[r.attributeName]
+		if !exists {
+			continue
+		}
+
 		var val string
 		err := runner.EvaluateExpr(attribute.Expr, &val, nil)
 
-		return runner.EnsureNoError(err, func() error {
+		err = runner.EnsureNoError(err, func() error {
 			if val == "" {
-				runner.EmitIssueOnExpr(
+				runner.EmitIssue(
 					r,
 					"TODO",
-					attribute.Expr,
+					attribute.Expr.Range(),
 				)
 			}
 			return nil
 		})
-	})
+		if err != nil {
+			return err
+		}
+	}
+
+	return nil
 }