-
Notifications
You must be signed in to change notification settings - Fork 319
Commit 6e72f27
fix(core): Typing in generic + network (#700)
Supports:
#305
Related : #691 #692
1. Updated Mypy
2. Add a new dev script to allow easy reporting on Mypy errors (Using it
in the makefile)
4. fix various type errors (all over core)
```
Error Summary
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━┓
┃ File Path ┃ Errors ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━┩
│ core/testcontainers/core/version.py │ 12 │
│ core/testcontainers/core/docker_client.py │ 14 │
│ core/testcontainers/core/network.py │ 4 │
│ core/testcontainers/core/image.py │ 17 │
│ core/testcontainers/core/waiting_utils.py │ 8 │
│ core/testcontainers/core/container.py │ 20 │
│ core/tests/test_new_docker_api.py │ 4 │
│ core/tests/test_docker_in_docker.py │ 2 │
│ core/testcontainers/compose/compose.py │ 22 │
│ core/testcontainers/compose/__init__.py │ 2 │
│ core/testcontainers/core/generic.py │ 1 │
│ core/tests/test_version.py │ 2 │
│ core/tests/test_ryuk.py │ 2 │
│ core/tests/test_registry.py │ 1 │
│ core/tests/test_network.py │ 1 │
│ core/tests/test_labels.py │ 1 │
│ core/tests/test_image.py │ 3 │
│ core/tests/test_docker_client.py │ 1 │
│ core/tests/conftest.py │ 1 │
│ core/tests/test_compose.py │ 7 │
└───────────────────────────────────────────┴────────┘
Found 125 errors in 20 files.
```
```
Error Summary
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━┓
┃ File Path ┃ Errors ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━┩
│ core/testcontainers/core/version.py │ 12 │
│ core/testcontainers/core/docker_client.py │ 14 │
│ core/testcontainers/core/image.py │ 17 │
│ core/testcontainers/core/waiting_utils.py │ 8 │
│ core/testcontainers/core/container.py │ 20 │
│ core/tests/test_new_docker_api.py │ 4 │
│ core/tests/test_docker_in_docker.py │ 2 │
│ core/testcontainers/compose/compose.py │ 22 │
│ core/testcontainers/compose/__init__.py │ 2 │
│ core/tests/test_version.py │ 2 │
│ core/tests/test_ryuk.py │ 2 │
│ core/tests/test_registry.py │ 1 │
│ core/tests/test_image.py │ 3 │
│ core/tests/test_compose.py │ 7 │
└───────────────────────────────────────────┴────────┘
Found 116 errors in 14 files.
```
---------
Co-authored-by: David Ankin <[email protected]>1 parent 3db24ac commit 6e72f27Copy full SHA for 6e72f27
Expand file treeCollapse file tree
1 file changed
+1
-1
lines changed+1-1Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments