Skip to content

Commit 40c041c

Browse files
eps1lonKent C. Dodds
authored and
Kent C. Dodds
committed
fix(fireEvent): various event defaults (#296)
* fix(fireEvent): compositionUpdate is cancelable * fix(events): input is not cancelable * fix(events): change is not cancelable and not an InputEvent * fix(events): mouseenter doesnt bubble nor is cancelable * fix(events): mouseleave not cancelor nor bubbles
1 parent 377c4a7 commit 40c041c

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/events.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const eventMap = {
2323
},
2424
compositionUpdate: {
2525
EventType: 'CompositionEvent',
26-
defaultInit: {bubbles: true, cancelable: false},
26+
defaultInit: {bubbles: true, cancelable: true},
2727
},
2828
// Keyboard Events
2929
keyDown: {
@@ -57,12 +57,12 @@ const eventMap = {
5757
},
5858
// Form Events
5959
change: {
60-
EventType: 'InputEvent',
61-
defaultInit: {bubbles: true, cancelable: true},
60+
EventType: 'Event',
61+
defaultInit: {bubbles: true, cancelable: false},
6262
},
6363
input: {
6464
EventType: 'InputEvent',
65-
defaultInit: {bubbles: true, cancelable: true},
65+
defaultInit: {bubbles: true, cancelable: false},
6666
},
6767
invalid: {
6868
EventType: 'Event',
@@ -123,11 +123,11 @@ const eventMap = {
123123
},
124124
mouseEnter: {
125125
EventType: 'MouseEvent',
126-
defaultInit: {bubbles: true, cancelable: true},
126+
defaultInit: {bubbles: false, cancelable: false},
127127
},
128128
mouseLeave: {
129129
EventType: 'MouseEvent',
130-
defaultInit: {bubbles: true, cancelable: true},
130+
defaultInit: {bubbles: false, cancelable: false},
131131
},
132132
mouseMove: {
133133
EventType: 'MouseEvent',

0 commit comments

Comments
 (0)