Skip to content

Commit abfec86

Browse files
committed
move default tags to ignore to config
1 parent 4b1099f commit abfec86

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

src/config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ let config = {
3333
_disableExpensiveErrorDiagnostics: false,
3434
}
3535

36+
export const DEFAULT_IGNORE_TAGS = 'script, style'
3637
export function runWithExpensiveErrorDiagnosticsDisabled(callback) {
3738
try {
3839
config._disableExpensiveErrorDiagnostics = true

src/queries/text.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import {wrapAllByQueryWithSuggestion} from '../query-helpers'
2+
import {DEFAULT_IGNORE_TAGS} from '../config'
23
import {
34
fuzzyMatches,
45
matches,
@@ -15,7 +16,7 @@ function queryAllByText(
1516
exact = true,
1617
collapseWhitespace,
1718
trim,
18-
ignore = 'script, style',
19+
ignore = DEFAULT_IGNORE_TAGS,
1920
normalizer,
2021
} = {},
2122
) {

src/suggestions.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ import {computeAccessibleName} from 'dom-accessibility-api'
22
import {getRoles} from './role-helpers'
33
import {getDefaultNormalizer} from './matches'
44
import {getNodeText} from './get-node-text'
5+
// eslint-disable-next-line import/no-cycle
6+
import {DEFAULT_IGNORE_TAGS} from './config'
57

68
const normalize = getDefaultNormalizer()
79

@@ -59,7 +61,7 @@ export function getSuggestedQuery(element, variant) {
5961
}
6062

6163
const textContent = normalize(getNodeText(element))
62-
if (textContent && !element.matches('script, style')) {
64+
if (textContent && !element.matches(DEFAULT_IGNORE_TAGS)) {
6365
return makeSuggestion('Text', textContent, {variant})
6466
}
6567

0 commit comments

Comments
 (0)