Skip to content

Test against multiple versions of React #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

snowystinger
Copy link
Contributor

@snowystinger snowystinger commented Jul 31, 2021

What:

Support running tests against multiple versions of React.

Why:

React 18 is coming soon and this library claims to support >=16.9

How:

Added a matrix of options to the github actions that will install other versions of React and run test against them

Checklist:

  • Documentation updated
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@@ -33,7 +33,6 @@
"scripts": {
"setup": "npm install && npm run validate -s",
"validate": "kcd-scripts validate",
"prepare": "npm run build",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a reminder that removing this means install will happen differently, build will no longer run on npm install, so it'll need to be done before packaging and publishing to npm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm pretty sure this was just left over from before we used semantic-release. We now have an explicit built in the release pipeline.

@codecov
Copy link

codecov bot commented Jul 31, 2021

Codecov Report

Merging #663 (acf5dd6) into main (7273ba4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #663   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          235       235           
  Branches        33        33           
=========================================
  Hits           235       235           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea92648...acf5dd6. Read the comment docs.

@mpeyper
Copy link
Member

mpeyper commented Jul 31, 2021

Don't worry about the required checks. I'll update them when this is merged.

@mpeyper mpeyper merged commit d946e3c into testing-library:main Aug 1, 2021
@snowystinger snowystinger deleted the support-testing-multiple-versions branch August 23, 2021 16:18
@github-actions
Copy link

🎉 This PR is included in version 7.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants