-
Notifications
You must be signed in to change notification settings - Fork 232
Test against multiple versions of React #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against multiple versions of React #663
Conversation
@@ -33,7 +33,6 @@ | |||
"scripts": { | |||
"setup": "npm install && npm run validate -s", | |||
"validate": "kcd-scripts validate", | |||
"prepare": "npm run build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a reminder that removing this means install will happen differently, build will no longer run on npm install, so it'll need to be done before packaging and publishing to npm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm pretty sure this was just left over from before we used semantic-release. We now have an explicit built in the release pipeline.
Codecov Report
@@ Coverage Diff @@
## main #663 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 235 235
Branches 33 33
=========================================
Hits 235 235 Continue to review full report at Codecov.
|
Don't worry about the required checks. I'll update them when this is merged. |
🎉 This PR is included in version 7.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
Support running tests against multiple versions of React.
Why:
React 18 is coming soon and this library claims to support >=16.9
How:
Added a matrix of options to the github actions that will install other versions of React and run
test
against themChecklist: