Skip to content

chore(ci): clean up validate scripts to remove duplication #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

mpeyper
Copy link
Member

@mpeyper mpeyper commented Aug 1, 2021

What:

Refactor Build scripts.

Why:

After merging #663 I had an idea to remove some of the duplication between the scripts in package.json and validate.yml.

How:

Using env variables to set the desired version each script can simple call a base script that defines which dependencies need the set version installed.

Checklist:

  • Ready to be merged

I'll merge this once the checks pass.

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #664 (6180b33) into main (d946e3c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #664   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          235       235           
  Branches        33        33           
=========================================
  Hits           235       235           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d946e3c...6180b33. Read the comment docs.

@mpeyper mpeyper merged commit 238a9ea into main Aug 1, 2021
@mpeyper mpeyper deleted the chore/ci-cleanup branch August 1, 2021 13:56
@github-actions
Copy link

🎉 This PR is included in version 7.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant