Skip to content

Commit 16e0536

Browse files
committed
fixup: move dependency installs to a script
1 parent 90bb3dd commit 16e0536

File tree

3 files changed

+20
-7
lines changed

3 files changed

+20
-7
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,7 @@ jobs:
5151
node-version: ${{ matrix.node }}
5252

5353
- name: 📥 Download deps
54-
run: |
55-
npm install --no-package-lock
56-
npm install --no-save svelte@${SVELTE_VERSION} @sveltejs/vite-plugin-svelte@${VITE_PLUGIN_VERSION}
57-
env:
58-
SVELTE_VERSION: ${{ matrix.svelte }}
59-
VITE_PLUGIN_VERSION: ${{ matrix.svelte == '5' && '4' || matrix.svelte == '4' && '3' || '2' }}
54+
run: ./scripts/install-dependencies ${{ matrix.svelte }}
6055

6156
- name: ▶️ Run ${{ matrix.check }}
6257
run: npm run ${{ matrix.check }}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
},
9696
"devDependencies": {
9797
"@jest/globals": "^29.7.0",
98-
"@sveltejs/vite-plugin-svelte": "^3.0.0 || ^4.0.0",
98+
"@sveltejs/vite-plugin-svelte": "^2.0.0 || ^3.0.0 || ^4.0.0",
9999
"@testing-library/jest-dom": "^6.3.0",
100100
"@testing-library/user-event": "^14.5.2",
101101
"@typescript-eslint/eslint-plugin": "^8.0.0",

scripts/install-dependencies

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
#!/usr/bin/env bash
2+
# Install dependencies for a given version of Svelte
3+
set -euo pipefail
4+
5+
svelte_version=${1}
6+
7+
rm -rf node_modules
8+
npm install --no-package-lock
9+
10+
if [[ "${svelte_version}" == "4" ]]; then
11+
npm uninstall --no-save @sveltejs/vite-plugin-svelte svelte
12+
npm install --no-save @sveltejs/vite-plugin-svelte@3 svelte@4
13+
elif [[ "${svelte_version}" == "3" ]]; then
14+
npm uninstall --no-save vite vitest @vitest/coverage-v8 @sveltejs/vite-plugin-svelte svelte-check svelte
15+
npm install --no-save vite@4 vitest@1 @vitest/coverage-v8@1 @sveltejs/vite-plugin-svelte@2 svelte-check@3 svelte@3
16+
fi
17+
18+
npm ls --depth=0 svelte

0 commit comments

Comments
 (0)