Skip to content

Fix a typo #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2019
Merged

Fix a typo #156

merged 1 commit into from
Jun 21, 2019

Conversation

huyenltnguyen
Copy link
Contributor

Changed react to React.

@kentcdodds kentcdodds merged commit 8f39f1e into testing-library:master Jun 21, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @huyenltnguyen for docs

@allcontributors
Copy link
Contributor

@kentcdodds

We had trouble processing your request. Please try again later.

@kentcdodds
Copy link
Member

@all-contributors please add @huyenltnguyen for docs

@allcontributors allcontributors bot mentioned this pull request Jun 21, 2019
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @huyenltnguyen! 🎉

@allcontributors allcontributors bot mentioned this pull request Jun 21, 2019
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @huyenltnguyen! 🎉

@kentcdodds
Copy link
Member

lol, I forgot you were already added @huyenltnguyen 😅

@huyenltnguyen
Copy link
Contributor Author

@kentcdodds lol, thanks for the super quick review and merge! 👍

Btw, do you think the error handler for this case could be improved, to add some more specific detail to the comment instead of a generic 'something went wrong'?

I'm happy to give it a stab.

@huyenltnguyen huyenltnguyen deleted the huyenltnguyen-patch-1 branch June 21, 2019 15:52
@kentcdodds
Copy link
Member

Go for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afontcu afontcu afontcu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huyenltnguyen @kentcdodds @afontcu