Merge pull request SeleniumHQ#529 from Remi-p/master

Config generation at runtime + buildtime

Author: ddavison

NodeBase/entry_point.sh

@@ -1,6 +1,7 @@
 #!/bin/bash
 
 source /opt/bin/functions.sh
+/opt/bin/generate_config > /opt/selenium/config.json
 
 export GEOMETRY="$SCREEN_WIDTH""x""$SCREEN_HEIGHT""x""$SCREEN_DEPTH"
 

NodeChrome/Dockerfile.txt

@@ -40,5 +40,5 @@ COPY generate_config /opt/bin/generate_config
 #=================================
 COPY chrome_launcher.sh /opt/google/chrome/google-chrome
 
-# Generating config inside the image rather than with entry_point.sh
+# Generating a default config during build time
 RUN /opt/bin/generate_config > /opt/selenium/config.json

NodeChromeDebug/entry_point.sh

@@ -3,6 +3,7 @@
 # IMPORTANT: Change this file only in directory NodeDebug!
 
 source /opt/bin/functions.sh
+/opt/bin/generate_config > /opt/selenium/config.json
 
 export GEOMETRY="$SCREEN_WIDTH""x""$SCREEN_HEIGHT""x""$SCREEN_DEPTH"
 

NodeDebug/entry_point.sh

@@ -3,6 +3,7 @@
 # IMPORTANT: Change this file only in directory NodeDebug!
 
 source /opt/bin/functions.sh
+/opt/bin/generate_config > /opt/selenium/config.json
 
 export GEOMETRY="$SCREEN_WIDTH""x""$SCREEN_HEIGHT""x""$SCREEN_DEPTH"
 

NodeFirefox/Dockerfile.txt

@@ -36,5 +36,5 @@ COPY generate_config /opt/bin/generate_config
 # When logging into the container
 RUN sudo echo ""
 
-# Generating config inside the image rather than with entry_point.sh
+# Generating a default config during build time
 RUN /opt/bin/generate_config > /opt/selenium/config.json

NodeFirefoxDebug/entry_point.sh

@@ -3,6 +3,7 @@
 # IMPORTANT: Change this file only in directory NodeDebug!
 
 source /opt/bin/functions.sh
+/opt/bin/generate_config > /opt/selenium/config.json
 
 export GEOMETRY="$SCREEN_WIDTH""x""$SCREEN_HEIGHT""x""$SCREEN_DEPTH"