Skip to content

Commit 1fd09e4

Browse files
committed
fix: Disabling introspection
Pass enabled argument to service
1 parent ff54b69 commit 1fd09e4

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

DependencyInjection/GraphQLiteCompilerPass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ public function process(ContainerBuilder $container): void
162162
// ServerConfig rules
163163
$serverConfigDefinition = $container->findDefinition(ServerConfig::class);
164164
$rulesDefinition = [];
165-
if ($container->getParameter('graphqlite.security.introspection') === false) {
165+
if ($container->getParameter('graphqlite.security.disableIntrospection')) {
166166
$rulesDefinition[] = $container->findDefinition(DisableIntrospection::class);
167167
}
168168

DependencyInjection/GraphQLiteExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ function($namespace): string {
7272
$container->setParameter('graphqlite.namespace.types', $namespaceType);
7373
$container->setParameter('graphqlite.security.enable_login', $enableLogin);
7474
$container->setParameter('graphqlite.security.enable_me', $enableMe);
75-
$container->setParameter('graphqlite.security.introspection', $config['security']['introspection'] ?? true);
75+
$container->setParameter('graphqlite.security.disableIntrospection', !($config['security']['introspection'] ?? true));
7676
$container->setParameter('graphqlite.security.maximum_query_complexity', $config['security']['maximum_query_complexity'] ?? null);
7777
$container->setParameter('graphqlite.security.maximum_query_depth', $config['security']['maximum_query_depth'] ?? null);
7878
$container->setParameter('graphqlite.security.firewall_name', $config['security']['firewall_name'] ?? 'main');

Resources/config/container/graphqlite.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,9 @@
7474
</call>
7575
</service>
7676

77-
<service id="GraphQL\Validator\Rules\DisableIntrospection" />
77+
<service id="GraphQL\Validator\Rules\DisableIntrospection">
78+
<argument key="$enabled">%graphqlite.security.disableIntrospection%</argument>
79+
</service>
7880

7981
<service id="GraphQL\Validator\Rules\QueryComplexity" />
8082

Tests/FunctionalTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ public function testWithIntrospection(): void
457457

458458
public function testDisableIntrospection(): void
459459
{
460-
$kernel = new GraphQLiteTestingKernel(true, null, true, null, false, 2, 2);
460+
$kernel = new GraphQLiteTestingKernel(true, null, true, null, false, 3, 2);
461461
$kernel->boot();
462462

463463
$parameters = ['query' => '

0 commit comments

Comments
 (0)