Only one call to $parameter->getType()

moufmouf · web-flow · commit c5ad0db46c3e · 2020-12-01T08:58:38.000+01:00
diff --git a/Mappers/RequestParameterMiddleware.php b/Mappers/RequestParameterMiddleware.php
@@ -18,7 +18,8 @@ class RequestParameterMiddleware implements ParameterMiddlewareInterface
 
     public function mapParameter(ReflectionParameter $parameter, DocBlock $docBlock, ?Type $paramTagType, ParameterAnnotations $parameterAnnotations, ParameterHandlerInterface $next): ParameterInterface
     {
-        if ($parameter->getType() and $parameter->getType()->getName() === Request::class) {
+        $parameterType = $parameter->getType();
+        if ($parameterType && $parameterType->getName() === Request::class) {
             return new RequestParameter();
         }
         return $next->mapParameter($parameter, $docBlock, $paramTagType, $parameterAnnotations);

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,8 @@ class RequestParameterMiddleware implements ParameterMiddlewareInterface`
`18`	`18`
`19`	`19`	`public function mapParameter(ReflectionParameter $parameter, DocBlock $docBlock, ?Type $paramTagType, ParameterAnnotations $parameterAnnotations, ParameterHandlerInterface $next): ParameterInterface`
`20`	`20`	`{`
`21`		`- if ($parameter->getType() and $parameter->getType()->getName() === Request::class) {`
	`21`	`+ $parameterType = $parameter->getType();`
	`22`	`+ if ($parameterType && $parameterType->getName() === Request::class) {`
`22`	`23`	`return new RequestParameter();`
`23`	`24`	`}`
`24`	`25`	`return $next->mapParameter($parameter, $docBlock, $paramTagType, $parameterAnnotations);`