Skip to content

symfony 6 (requires SF 5.3+) #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2022
Merged

Conversation

janatjak
Copy link
Contributor

No description provided.

@faizanakram99 faizanakram99 mentioned this pull request Feb 1, 2022
@mistraloz
Copy link
Collaborator

Thanks for your PR but some tests failed. I'm not sure of why but if you need, you can remove some support (php7.2 and 7.3) and can remove too (if required or better) support for symfony 5.3 (just keep ^5.4 | ^6). If you change the CI, please try to add one for php 8.1.
This PR will be merged on a new 5.4.x tag.

@n-ramdi
Copy link

n-ramdi commented Feb 18, 2022

Hello and thanks for your PR,
Any up for this plz?

@faizanakram99
Copy link
Contributor

faizanakram99 commented Feb 22, 2022

@janatjak Thanks for the PR. Are you still working on this ? If not, I can try to pick it up

cleanup travis matrix
@janatjak
Copy link
Contributor Author

I have added new requirements, PHP 7.4+ & SF 5.4+ and updated Travis matrix

@faizanakram99 pls check last commit ;)

@swangee
Copy link

swangee commented Apr 26, 2022

Hello, any updates? We would like to update Symfony in our project, but waiting for this PR to be merged.

@wollukav
Copy link

wollukav commented May 6, 2022

Hello!
The same for us. It is one of the blockers for migrating to Symfony6.
Do you have plans to merge and release it or we should use a fork?

@janatjak
Copy link
Contributor Author

ping @faizanakram99

please rerun pipelines, thanks 🙏

@andrew-demb
Copy link
Collaborator

@devmaslov @moufmouf @nguyenk @npeguin could you help to proceed this PR, please?

@faizanakram99
Copy link
Contributor

ping @faizanakram99

please rerun pipelines, thanks 🙏

Oh, I'm not a maintainer, just a concerned developer like you

@mistraloz mistraloz merged commit 972bbfb into thecodingmachine:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants