Skip to content

Revert "symfony 6 (requires SF 5.3+)" #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "symfony 6 (requires SF 5.3+)" #129

wants to merge 1 commit into from

Conversation

mistraloz
Copy link
Collaborator

Reverts #119

@andrew-demb
Copy link
Collaborator

Is it broke something?

@mistraloz mistraloz closed this May 18, 2022
@mistraloz
Copy link
Collaborator Author

Yes we unit testing are failed. But it's fail with the PR and without the PR. I'm not sure for nothing -_-'

@andrew-demb
Copy link
Collaborator

It fails (after reverting) because of allowed symfony/http-kernel:6 and not compatible code.

@andrew-demb
Copy link
Collaborator

Here is PR with fixes: #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistraloz @andrew-demb