[Fix] Fix StaticTypeMapper method calls by moving definition #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-demb
requested changes
Jun 6, 2025
cvergne
force-pushed
the
fix/247-statictypemapper-methods-to-constructor
branch
from
225f5d2 to
369d3c3
Compare
cvergne
force-pushed
the
fix/247-statictypemapper-methods-to-constructor
branch
from
369d3c3 to
edb430e
Compare
|
Well finally we'll need to standby this PR until a release of the graphqlite library to have this fix available. Handling your feedbacks showed wrong fixtures so I fixed them but we need the main library fix to be ok. |
andrew-demb
approved these changes
Jun 6, 2025
|
Graphqlite now tagged. I've retried CI - now it's green. Thanks @cvergne |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247.
Hello,
Since the 7.0 of Graphqlite Library (and specifically "Immutability improvements" in thecodingmachine/graphqlite#584), the StaticTypeMapper class signature has changed from method calls to constructor arguments.
This case was not covered in tests of the bundle so I have first added a custom type in test fixtures and so fixed the definition from XML+method calls to definition directly in compilerpass.