Skip to content

Use merged bundle config to allow overrides #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2021
Merged

Use merged bundle config to allow overrides #86

merged 1 commit into from
May 31, 2021

Conversation

TamasSzigeti
Copy link
Contributor

@TamasSzigeti TamasSzigeti commented Mar 8, 2021

Hi, awesome package!

I found this small bug when I tried to add extra namespaces on test env for some fixture queries/types

@TamasSzigeti TamasSzigeti marked this pull request as ready for review March 8, 2021 08:15
Copy link
Collaborator

@devmaslov devmaslov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TamasSzigeti, thanks for bringing this up. Looks good to me!

@moufmouf I can help maintaining this repo as well.
Could you share more info on our release process?
At least the following questions interest me:

  • Who can do this?
  • How often are we doing releases? After each PR merge to master?

@TamasSzigeti
Copy link
Contributor Author

@moufmouf It is really great that you involved @devmaslov and @oojacoboo as maintainers, but maybe they also need to be empowered to merge PRs and cut releases to make things move a bit more swiftly? Or is there anything blocking for example this PR to be merged and released?

@moufmouf
Copy link
Member

Oh jee, sorry, I completely missed that PR.

@devmaslov you are maintainer of this package.
I completely trust you to merge and tag a new release if you deem it necessary.

One important thing about graphqlite-bundle: I think it is better if we keep the version number in sync with GraphQLite.

So graphqlite-bundle 4.1.x is compatible with graphqlite 4.1.x.
This means that graphqlite-bundle does not strictly follow semver. For instance, we could add a new feature in a "patch" release.

@moufmouf moufmouf merged commit 18e26ff into thecodingmachine:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants