Handle FuncCall nodes that represent first class callables

Author: spawnia

composer.json

@@ -15,6 +15,7 @@
         "thecodingmachine/safe": "^1.0 || ^2.0"
     },
     "require-dev": {
+        "nikic/php-parser": "^4",
         "phpunit/phpunit": "^7.5.2 || ^8.0",
         "php-coveralls/php-coveralls": "^2.1",
         "squizlabs/php_codesniffer": "^3.4"

src/Rules/UseSafeFunctionsRule.php

@@ -21,6 +21,11 @@
  */
 class UseSafeFunctionsRule implements Rule
 {
+    /**
+     * @see JSON_THROW_ON_ERROR
+     */
+    const JSON_THROW_ON_ERROR = 4194304;
+
     public function getNodeType(): string
     {
         return Node\Expr\FuncCall::class;
@@ -40,19 +45,18 @@ public function processNode(Node $node, Scope $scope): array
         $unsafeFunctions = FunctionListLoader::getFunctionList();
 
         if (isset($unsafeFunctions[$functionName])) {
-            if (version_compare(PHP_VERSION, '7.3.0', '>=')) {
+            if (version_compare(PHP_VERSION, '7.3.0', '>=') && ! $node->isFirstClassCallable()) {
                 if ($functionName === "json_decode") {
-                    if (count($node->args) == 4) {
-                        if ($this->argValueIncludeJSONTHROWONERROR($node->args[3])) {
-                            return [];
-                        }
+                    $args = $node->getArgs();
+                    if (count($args) == 4 && $this->argValueIncludeJSONTHROWONERROR($args[3])) {
+                        return [];
                     }
                 }
+
                 if ($functionName === "json_encode") {
-                    if (count($node->args) >= 2) {
-                        if ($this->argValueIncludeJSONTHROWONERROR($node->args[1])) {
-                            return [];
-                        }
+                    $args = $node->getArgs();
+                    if (count($args) >= 2 && $this->argValueIncludeJSONTHROWONERROR($args[1])) {
+                        return [];
                     }
                 }
             }
@@ -83,8 +87,7 @@ private function argValueIncludeJSONTHROWONERROR(Arg $arg): bool
         }
 
         return in_array(true, array_map(function ($element) {
-            // JSON_THROW_ON_ERROR == 4194304
-            return ($element & 4194304) == 4194304;
+            return ($element & self::JSON_THROW_ON_ERROR) == self::JSON_THROW_ON_ERROR;
         }, array_filter($options, function ($element) {
             return is_int($element);
         })));

src/Type/Php/ReplaceSafeFunctionsDynamicReturnTypeExtension.php

@@ -50,11 +50,12 @@ private function getPreliminarilyResolvedTypeFromFunctionCall(
         Scope $scope
     ): Type {
         $argumentPosition = $this->functions[$functionReflection->getName()];
-        if (count($functionCall->args) <= $argumentPosition) {
+        $args = $functionCall->getArgs();
+        if (count($args) <= $argumentPosition) {
             return ParametersAcceptorSelector::selectSingle($functionReflection->getVariants())->getReturnType();
         }
 
-        $subjectArgumentType = $scope->getType($functionCall->args[$argumentPosition]->value);
+        $subjectArgumentType = $scope->getType($args[$argumentPosition]->value);
         $defaultReturnType = ParametersAcceptorSelector::selectSingle($functionReflection->getVariants())->getReturnType();
         if ($subjectArgumentType instanceof MixedType) {
             return TypeUtils::toBenevolentUnion($defaultReturnType);