Skip to content

Test on PHP 8 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Test on PHP 8 #22

wants to merge 6 commits into from

Conversation

sanmai
Copy link
Contributor

@sanmai sanmai commented Aug 30, 2020 •
edited
Loading

Follow-up to #21

TBH I'm a bit puzzled by the build errors, will be going to look into them later.

@coveralls
Copy link

coveralls commented Aug 30, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 80

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.838%
Totals Coverage Status
Change from base Build 73: 0.0%
Covered Lines: 65
Relevant Lines: 74
💛 - Coveralls

@sanmai
Copy link
Contributor Author

sanmai commented Aug 31, 2020 •
edited
Loading

The problem with:

ParseError: syntax error, unexpected token "match", expecting variable

Appears to have this explanation:

sebastianbergmann/phpunit#4373

@sanmai sanmai mentioned this pull request Aug 31, 2020
Merged
16 tasks
@dbrekelmans
Copy link
Collaborator

I'm going to close this since it's from 2020 🙈, also seems to be resolved by #35 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanmai @coveralls @dbrekelmans