rubocop autocorrect

Author: thejonroberts

Gemfile

@@ -39,7 +39,7 @@ gem "redis", ">= 4.0.1"
 # gem "bcrypt", "~> 3.1.7"
 
 # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
-gem "tzinfo-data", platforms: %i[ windows jruby ]
+gem "tzinfo-data", platforms: %i[windows jruby]
 
 # Reduces boot times through caching; required in config/boot.rb
 gem "bootsnap", require: false
@@ -50,10 +50,9 @@ gem "bootsnap", require: false
 gem "simple_form", "~> 5.3"
 gem "devise", "~> 4.9"
 
-
 group :development, :test do
   # See https://guides.rubyonrails.org/debugging_rails_applications.html#debugging-with-the-debug-gem
-  gem "debug", platforms: %i[ mri windows ]
+  gem "debug", platforms: %i[mri windows]
   gem "dotenv", "~> 3.1"
 
   gem "rubocop"

app/controllers/line_item_dates_controller.rb

@@ -36,14 +36,14 @@ def update
   end
 
   def destroy
-  @line_item_date.destroy
+    @line_item_date.destroy
 
-  respond_to do |format|
-    notice = "Date was successfully destroyed."
-    format.html { redirect_to quote_path(@quote), notice: }
-    format.turbo_stream { flash.now[:notice] = notice }
+    respond_to do |format|
+      notice = "Date was successfully destroyed."
+      format.html { redirect_to quote_path(@quote), notice: }
+      format.turbo_stream { flash.now[:notice] = notice }
+    end
   end
-end
 
   private
 

app/controllers/line_items_controller.rb

@@ -39,11 +39,11 @@ def update
   def destroy
     @line_item.destroy
 
-  respond_to do |format|
-    notice = "Date was successfully destroyed."
-    format.html { redirect_to quote_path(@quote), notice: }
-    format.turbo_stream { flash.now[:notice] = notice }
-  end
+    respond_to do |format|
+      notice = "Date was successfully destroyed."
+      format.html { redirect_to quote_path(@quote), notice: }
+      format.turbo_stream { flash.now[:notice] = notice }
+    end
   end
 
   private

app/controllers/quotes_controller.rb

@@ -19,14 +19,14 @@ def create
     @quote = current_company.quotes.build(quote_params)
 
     if @quote.save
-    respond_to do |format|
-      notice = "Quote was successfully created."
-      format.html { redirect_to quotes_path, notice: }
-      format.turbo_stream { flash.now[:notice] = notice }
+      respond_to do |format|
+        notice = "Quote was successfully created."
+        format.html { redirect_to quotes_path, notice: }
+        format.turbo_stream { flash.now[:notice] = notice }
+      end
+    else
+      render :new, status: :unprocessable_entity
     end
-  else
-    render :new, status: :unprocessable_entity
-  end
   end
 
   def edit

app/models/line_item.rb

@@ -2,8 +2,8 @@ class LineItem < ApplicationRecord
   belongs_to :line_item_date
 
   validates :name, presence: true
-  validates :quantity, presence: true, numericality: { only_integer: true, greater_than: 0 }
-  validates :unit_price, presence: true, numericality: { greater_than: 0 }
+  validates :quantity, presence: true, numericality: {only_integer: true, greater_than: 0}
+  validates :unit_price, presence: true, numericality: {greater_than: 0}
 
   delegate :quote, to: :line_item_date
 

app/models/line_item_date.rb

@@ -1,12 +1,12 @@
 class LineItemDate < ApplicationRecord
   belongs_to :quote
-  has_many :line_items, dependent: :destroy #, strict_loading: true
+  has_many :line_items, dependent: :destroy # TODO:, strict_loading: true
 
-  validates :date, presence: true, uniqueness: { scope: :quote_id }
+  validates :date, presence: true, uniqueness: {scope: :quote_id}
 
   scope :ordered, -> { order(date: :asc) }
 
   def previous_date
-    quote.line_item_dates.ordered.where("date < ?", date).last
+    quote.line_item_dates.ordered.where(date: ...date).last
   end
 end

app/models/quote.rb

@@ -1,6 +1,6 @@
 class Quote < ApplicationRecord
   belongs_to :company
-  has_many :line_item_dates, dependent: :destroy #, strict_loading: true
+  has_many :line_item_dates, dependent: :destroy # TODO, strict_loading: true
   has_many :line_items, through: :line_item_dates
 
   validates :name, presence: true

config/application.rb

@@ -14,7 +14,7 @@ class Application < Rails::Application
     # Please, add to the `ignore` list any other `lib` subdirectories that do
     # not contain `.rb` files, or that should not be reloaded or eager loaded.
     # Common ones are `templates`, `generators`, or `middleware`, for example.
-    config.autoload_lib(ignore: %w(assets tasks))
+    config.autoload_lib(ignore: %w[assets tasks])
 
     # Configuration for the application, engines, and railties goes here.
     #

config/environments/production.rb

@@ -52,12 +52,12 @@
   config.force_ssl = true
 
   # Log to STDOUT by default
-  config.logger = ActiveSupport::Logger.new(STDOUT)
-    .tap  { |logger| logger.formatter = ::Logger::Formatter.new }
+  config.logger = ActiveSupport::Logger.new($stdout)
+    .tap { |logger| logger.formatter = ::Logger::Formatter.new }
     .then { |logger| ActiveSupport::TaggedLogging.new(logger) }
 
   # Prepend all log lines with the following tags.
-  config.log_tags = [ :request_id ]
+  config.log_tags = [:request_id]
 
   # "info" includes generic and useful information about system operation, but avoids logging too much
   # information to avoid inadvertent exposure of personally identifiable information (PII). If you

config/initializers/devise.rb

@@ -24,7 +24,7 @@
   # Configure the e-mail address which will be shown in Devise::Mailer,
   # note that it will be overwritten if you use your own mailer class
   # with default "from" parameter.
-  config.mailer_sender = '[email protected]'
+  config.mailer_sender = "[email protected]"
 
   # Configure the class responsible to send e-mails.
   # config.mailer = 'Devise::Mailer'
@@ -36,7 +36,7 @@
   # Load and configure the ORM. Supports :active_record (default) and
   # :mongoid (bson_ext recommended) by default. Other ORMs may be
   # available as additional gems.
-  require 'devise/orm/active_record'
+  require "devise/orm/active_record"
 
   # ==> Configuration for any authentication mechanism
   # Configure which keys are used when authenticating a user. The default is

config/initializers/simple_form.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-#
+
 # Uncomment this and change the path if necessary to include your own
 # components.
 # See https://github.com/heartcombo/simple_form#custom-components to know
@@ -68,11 +68,11 @@
     # b.use :full_error, wrap_with: { tag: :span, class: :error }
   end
 
-# Default configuration FROM TUTORIAL
+  # Default configuration FROM TUTORIAL
   config.generate_additional_classes_for = []
   # config.default_wrapper                 = :default
   # config.button_class                    = "btn"
-  config.label_text                      = lambda { |label, _, _| label }
+  config.label_text = lambda { |label, _, _| label }
   # config.error_notification_tag          = :div
   # config.error_notification_class        = "error_notification"
 
@@ -86,7 +86,7 @@
   config.boolean_style = :nested
 
   # Default class for buttons
-  config.button_class = 'btn'
+  config.button_class = "btn"
 
   # Method used to tidy up errors. Specify any Rails Array method.
   # :first lists the first message for each field.
@@ -97,7 +97,7 @@
   config.error_notification_tag = :div
 
   # CSS class to add for error notification helper.
-  config.error_notification_class = 'error_notification'
+  config.error_notification_class = "error_notification"
 
   # Series of attempts to detect a default label method for collection.
   # config.collection_label_methods = [ :to_label, :name, :title, :to_s ]
@@ -173,7 +173,7 @@
   # config.input_class = nil
 
   # Define the default class of the input wrapper of the boolean input.
-  config.boolean_label_class = 'checkbox'
+  config.boolean_label_class = "checkbox"
 
   # Defines if the default input wrapper class should be included in radio
   # collection wrappers.

config/routes.rb

@@ -4,7 +4,7 @@
 
   # Reveal health status on /up that returns 200 if the app boots with no exceptions, otherwise 500.
   # Can be used by load balancers and uptime monitors to verify that the app is live.
-  get "up" => "rails/health#show", as: :rails_health_check
+  get "up" => "rails/health#show", :as => :rails_health_check
 
   root to: "pages#home"
 

db/seeds.rb

@@ -8,5 +8,5 @@
 #     MovieGenre.find_or_create_by!(name: genre_name)
 #   end
 
-puts "\n== Seeding the database with fixtures =="
+Rails.logger.debug "\n== Seeding the database with fixtures =="
 system("bin/rails db:fixtures:load")

test/controllers/quotes_controller_test.rb

@@ -18,7 +18,7 @@ class QuotesControllerTest < ActionDispatch::IntegrationTest
 
   test "should create quote" do
     assert_difference("Quote.count") do
-      post quotes_url, params: { quote: { name: 'test quote' } }
+      post quotes_url, params: {quote: {name: "test quote"}}
     end
 
     assert_redirected_to quotes_url
@@ -35,8 +35,7 @@ class QuotesControllerTest < ActionDispatch::IntegrationTest
   end
 
   test "should update quote" do
-    patch quote_url(@quote), params: { quote: { name: 'different name' } }
-    # assert_redirected_to quote_url(@quote)
+    patch quote_url(@quote), params: {quote: {name: "different name"}}
     assert_redirected_to quotes_url
   end
 

test/system/line_item_dates_test.rb

@@ -6,7 +6,7 @@ class LineItemDatesTest < ApplicationSystemTestCase
   setup do
     login_as users(:accountant)
 
-    @quote          = quotes(:one)
+    @quote = quotes(:one)
     @line_item_date = line_item_dates(:today)
 
     visit quote_path(@quote)

test/system/line_items_test.rb

@@ -6,9 +6,9 @@ class LineItemSystemTest < ApplicationSystemTestCase
   setup do
     login_as users(:accountant)
 
-    @quote          = quotes(:one)
+    @quote = quotes(:one)
     @line_item_date = line_item_dates(:today)
-    @line_item      = line_items(:room_today)
+    @line_item = line_items(:room_today)
 
     visit quote_path(@quote)
   end