Merge pull request #20 from lukeholder/patch-1

Redirect response should not return `isSuccessful == true`

Author: delatbabel

src/Message/RestPurchaseResponse.php

@@ -2,6 +2,7 @@
 /**
  * MultiSafepay Rest Api Purchase Response.
  */
+
 namespace Omnipay\MultiSafepay\Message;
 
 use Omnipay\Common\Message\RedirectResponseInterface;
@@ -88,6 +89,20 @@
  */
 class RestPurchaseResponse extends RestAbstractResponse implements RedirectResponseInterface
 {
+    /**
+     * Is the response successful?
+     *
+     * @return bool
+     */
+    public function isSuccessful()
+    {
+        if ($this->isRedirect()) {
+            return false;
+        }
+
+        return parent::isSuccessful();
+    }
+
     /**
      * {@inheritdoc}
      */
@@ -101,8 +116,8 @@ public function isRedirect()
      */
     public function getRedirectUrl()
     {
-        if (! $this->isRedirect()) {
-            return null;
+        if (!$this->isRedirect()) {
+            return;
         }
 
         return $this->data['data']['payment_url'];
@@ -121,6 +136,6 @@ public function getRedirectMethod()
      */
     public function getRedirectData()
     {
-        return null;
+        return;
     }
 }

tests/Message/RestPurchaseRequestTest.php

@@ -46,7 +46,7 @@ public function testSendSuccess()
 
         $response = $this->request->send();
 
-        $this->assertTrue($response->isSuccessful());
+        $this->assertFalse($response->isSuccessful());
         $this->assertTrue($response->isRedirect());
 
         $this->assertEquals(