Skip to content

Commit 7a7ac99

Browse files
sync with github
1 parent f4e8df0 commit 7a7ac99

File tree

3 files changed

+32
-37
lines changed

3 files changed

+32
-37
lines changed

php7/memcache.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ static zend_class_entry *memcache_ce;
3636

3737
ZEND_EXTERN_MODULE_GLOBALS(memcache)
3838

39-
4039
/* {{{ memcache_functions[]
4140
*/
4241
ZEND_BEGIN_ARG_INFO(arginfo_memcache_get, 1)
@@ -317,10 +316,10 @@ PHP_MINIT_FUNCTION(memcache)
317316
#endif
318317

319318
REGISTER_LONG_CONSTANT("MEMCACHE_COMPRESSED", MMC_COMPRESSED, CONST_CS | CONST_PERSISTENT);
320-
REGISTER_LONG_CONSTANT("MEMCACHE_USER1", MMC_RESERVED_APPLICATIONDEFINEDFLAG_12, CONST_CS | CONST_PERSISTENT);
321-
REGISTER_LONG_CONSTANT("MEMCACHE_USER2", MMC_RESERVED_APPLICATIONDEFINEDFLAG_13, CONST_CS | CONST_PERSISTENT);
322-
REGISTER_LONG_CONSTANT("MEMCACHE_USER3", MMC_RESERVED_APPLICATIONDEFINEDFLAG_14, CONST_CS | CONST_PERSISTENT);
323-
REGISTER_LONG_CONSTANT("MEMCACHE_USER4", MMC_RESERVED_APPLICATIONDEFINEDFLAG_15, CONST_CS | CONST_PERSISTENT);
319+
REGISTER_LONG_CONSTANT("MEMCACHE_USER1", MMC_RESERVED_APPLICATIONDEFINEDFLAG_12, CONST_CS | CONST_PERSISTENT);
320+
REGISTER_LONG_CONSTANT("MEMCACHE_USER2", MMC_RESERVED_APPLICATIONDEFINEDFLAG_13, CONST_CS | CONST_PERSISTENT);
321+
REGISTER_LONG_CONSTANT("MEMCACHE_USER3", MMC_RESERVED_APPLICATIONDEFINEDFLAG_14, CONST_CS | CONST_PERSISTENT);
322+
REGISTER_LONG_CONSTANT("MEMCACHE_USER4", MMC_RESERVED_APPLICATIONDEFINEDFLAG_15, CONST_CS | CONST_PERSISTENT);
324323
REGISTER_INI_ENTRIES();
325324

326325
#if HAVE_MEMCACHE_SESSION
@@ -655,7 +654,6 @@ static void php_mmc_numeric(INTERNAL_FUNCTION_PARAMETERS, int deleted, int inver
655654

656655
/* begin sending requests immediatly */
657656
mmc_pool_select(pool);
658-
659657
} ZEND_HASH_FOREACH_END();
660658

661659
}

php7/memcache_binary_protocol.c

Lines changed: 26 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ typedef struct mmc_response_header {
147147
uint16_t status;
148148
uint32_t length; /* trailing body length (not including this header) */
149149
uint32_t reqid; /* echo'ed from request */
150-
uint64_t cas;
150+
uint64_t cas;
151151
} mmc_response_header_t;
152152

153153
typedef struct mmc_get_response_header {
@@ -165,32 +165,31 @@ static int mmc_request_read_value(mmc_t *, mmc_request_t *);
165165
void mmc_binary_hexdump(void *mem, unsigned int len)
166166
{
167167
# define HEXDUMP_COLS 4
168-
unsigned int i, j;
169-
170-
for(i = 0; i < len + ((len % HEXDUMP_COLS) ? (HEXDUMP_COLS - len % HEXDUMP_COLS) : 0); i++) {
171-
if(i % HEXDUMP_COLS == 0) {
172-
printf("%06i: ", i);
173-
}
174-
175-
if(i < len) {
176-
printf("%02x ", 0xFF & ((char*)mem)[i]);
177-
} else {
178-
printf(" ");
179-
}
180-
181-
if(i % HEXDUMP_COLS == (HEXDUMP_COLS - 1)) {
182-
for(j = i - (HEXDUMP_COLS - 1); j <= i; j++) {
183-
if(j >= len) {
184-
putchar(' ');
185-
} else if(isprint(((char*)mem)[j])) {
186-
putchar(0xFF & ((char*)mem)[j]);
187-
} else {
188-
putchar('.');
189-
}
190-
}
191-
putchar('\n');
192-
}
193-
}
168+
unsigned int i, j;
169+
for(i = 0; i < len + ((len % HEXDUMP_COLS) ? (HEXDUMP_COLS - len % HEXDUMP_COLS) : 0); i++) {
170+
if(i % HEXDUMP_COLS == 0) {
171+
printf("%06i: ", i);
172+
}
173+
174+
if(i < len) {
175+
printf("%02x ", 0xFF & ((char*)mem)[i]);
176+
} else {
177+
printf(" ");
178+
}
179+
180+
if(i % HEXDUMP_COLS == (HEXDUMP_COLS - 1)) {
181+
for(j = i - (HEXDUMP_COLS - 1); j <= i; j++) {
182+
if(j >= len) {
183+
putchar(' ');
184+
} else if(isprint(((char*)mem)[j])) {
185+
putchar(0xFF & ((char*)mem)[j]);
186+
} else {
187+
putchar('.');
188+
}
189+
}
190+
putchar('\n');
191+
}
192+
}
194193
}
195194
#ifdef PHP_WIN32
196195
uint64_t mmc_htonll(uint64_t value)
@@ -322,7 +321,6 @@ static int mmc_request_read_mutate(mmc_t *mmc, mmc_request_t *request) /*
322321
zval keytmp = *key;
323322

324323
zval_copy_ctor(&keytmp);
325-
INIT_PZVAL(&keytmp);
326324
convert_to_string(&keytmp);
327325

328326
result = request->value_handler(
@@ -394,7 +392,6 @@ static int mmc_request_read_value(mmc_t *mmc, mmc_request_t *request) /*
394392
zval keytmp = *key;
395393

396394
zval_copy_ctor(&keytmp);
397-
INIT_PZVAL(&keytmp);
398395
convert_to_string(&keytmp);
399396

400397
result = mmc_unpack_value(

php7/memcache_pool.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,9 @@ static unsigned int mmc_hash_fnv1a_combine(unsigned int seed, const void *key, u
8686
while (p < end) {
8787
seed ^= (unsigned int)*(p++);
8888
seed *= FNV_32_PRIME;
89-
}
89+
}
9090

91-
return seed;
91+
return seed;
9292
}
9393
/* }}} */
9494

0 commit comments

Comments
 (0)