trigger warning in to_sparse_data_frame()

Author: EmilHvitfeldt

R/sparsevctrs.R

@@ -7,7 +7,7 @@ to_sparse_data_frame <- function(x, object) {
         "!" = "{.arg x} is a sparse matrix, but model doesn't accept that.",
         "i" = "Converted {.arg x} to data.frame."
       ))
-      x <- as.data.frame(x)
+      x <- as.data.frame(as.matrix(x))
     }
   }
   x

tests/testthat/_snaps/sparsevctrs.md

@@ -1,3 +1,12 @@
+# sparse matrices can be passed to `fit_xy()
+
+    Code
+      lm_fit <- fit_xy(spec, x = hotel_data[1:100, -1], y = hotel_data[1:100, 1])
+    Condition
+      Warning:
+      ! `x` is a sparse matrix, but model doesn't accept that.
+      i Converted `x` to data.frame.
+
 # to_sparse_data_frame() is used correctly
 
     Code

tests/testthat/test-sparsevctrs.R

@@ -10,6 +10,14 @@ test_that("sparse matrices can be passed to `fit_xy()", {
   expect_no_error(
     lm_fit <- fit_xy(spec, x = hotel_data[, -1], y = hotel_data[, 1])
   )
+
+  spec <- linear_reg() %>%
+    set_mode("regression") %>%
+    set_engine("lm")
+
+  expect_snapshot(
+    lm_fit <- fit_xy(spec, x = hotel_data[1:100, -1], y = hotel_data[1:100, 1])
+  )
 })
 
 test_that("to_sparse_data_frame() is used correctly", {