Update tests for new errors

Author: juliasilge

tests/testthat/test_args_and_modes.R

@@ -49,6 +49,6 @@ test_that('pipe engine', {
 test_that("can't set a mode that isn't allowed by the model spec", {
   expect_error(
     set_mode(linear_reg(), "classification"),
-    "`mode` should be one of"
+    "Available modes are:"
   )
 })

tests/testthat/test_mars.R

@@ -111,7 +111,7 @@ test_that('updating', {
 })
 
 test_that('bad input', {
-  expect_warning(translate(mars(mode = "regression") %>% set_engine()))
+  expect_error(translate(mars(mode = "regression") %>% set_engine()))
   expect_error(translate(mars() %>% set_engine("wat?")))
   expect_error(translate(mars(formula = y ~ x)))
 })

tests/testthat/test_multinom_reg.R

@@ -123,6 +123,6 @@ test_that('updating', {
 test_that('bad input', {
   expect_error(multinom_reg(mode = "regression"))
   expect_error(translate(multinom_reg(penalty = 0.1) %>% set_engine("wat?")))
-  expect_warning(multinom_reg(penalty = 0.1) %>% set_engine())
+  expect_error(multinom_reg(penalty = 0.1) %>% set_engine())
   expect_warning(translate(multinom_reg(penalty = 0.1) %>% set_engine("glmnet", x = hpc[,1:3], y = hpc$class)))
 })

tests/testthat/test_nearest_neighbor.R

@@ -122,5 +122,5 @@ test_that('updating', {
 
 test_that('bad input', {
   expect_error(nearest_neighbor(mode = "reallyunknown"))
-  expect_warning(nearest_neighbor() %>% set_engine( NULL))
+  expect_error(nearest_neighbor() %>% set_engine( NULL))
 })

tests/testthat/test_nullmodel.R

@@ -32,7 +32,7 @@ test_that('engine arguments', {
 })
 
 test_that('bad input', {
-  expect_warning(translate(null_model(mode = "regression") %>% set_engine()))
+  expect_error(translate(null_model(mode = "regression") %>% set_engine()))
   expect_error(translate(null_model() %>% set_engine("wat?")))
   expect_error(translate(null_model(formula = y ~ x)))
   expect_warning(

tests/testthat/test_rand_forest.R

@@ -192,7 +192,7 @@ test_that('updating', {
 })
 
 test_that('bad input', {
-  expect_warning(translate(rand_forest(mode = "classification") %>% set_engine(NULL)))
+  expect_error(translate(rand_forest(mode = "classification") %>% set_engine(NULL)))
   expect_error(rand_forest(mode = "time series"))
   expect_error(translate(rand_forest(mode = "classification") %>% set_engine("wat?")))
   expect_error(translate(rand_forest(mode = "classification", ytest = 2)))

tests/testthat/test_surv_reg.R

@@ -85,7 +85,7 @@ test_that('bad input', {
 
   expect_error(surv_reg(mode = ", classification"))
   expect_error(translate(surv_reg() %>% set_engine("wat")))
-  expect_warning(translate(surv_reg() %>% set_engine(NULL)))
+  expect_error(translate(surv_reg() %>% set_engine(NULL)))
 })
 
 test_that("deprecation warning", {

tests/testthat/test_svm_linear.R

@@ -104,7 +104,7 @@ test_that('updating', {
 })
 
 test_that('bad input', {
-  expect_warning(translate(svm_linear(mode = "regression") %>% set_engine( NULL)))
+  expect_error(translate(svm_linear(mode = "regression") %>% set_engine( NULL)))
   expect_error(svm_linear(mode = "reallyunknown"))
   expect_error(translate(svm_linear(mode = "regression") %>% set_engine("LiblineaR", type = 3)))
   expect_error(translate(svm_linear(mode = "classification") %>% set_engine("LiblineaR", type = 11)))

tests/testthat/test_svm_liquidsvm.R

@@ -77,5 +77,5 @@ test_that('updating', {
 
 test_that('bad input', {
   expect_error(svm_rbf(mode = "reallyunknown"))
-  expect_warning(svm_rbf() %>% set_engine( NULL))
+  expect_error(svm_rbf() %>% set_engine( NULL))
 })

tests/testthat/test_svm_poly.R

@@ -106,7 +106,7 @@ test_that('updating', {
 
 test_that('bad input', {
   expect_error(svm_poly(mode = "reallyunknown"))
-  expect_warning(svm_poly() %>% set_engine(NULL))
+  expect_error(svm_poly() %>% set_engine(NULL))
 })
 
 # ------------------------------------------------------------------------------

tests/testthat/test_svm_rbf.R

@@ -87,7 +87,7 @@ test_that('updating', {
 
 test_that('bad input', {
   expect_error(svm_rbf(mode = "reallyunknown"))
-  expect_warning(translate(svm_rbf(mode = "regression") %>% set_engine( NULL)))
+  expect_error(translate(svm_rbf(mode = "regression") %>% set_engine( NULL)))
 })
 
 # ------------------------------------------------------------------------------