Skip to content

Commit 4dd0fb9

Browse files
committed
rename new_model_spec arg: new -> check_missing_spec
1 parent 51ef493 commit 4dd0fb9

File tree

5 files changed

+15
-6
lines changed

5 files changed

+15
-6
lines changed

R/arguments.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ set_args <- function(object, ...) {
6868
mode = object$mode,
6969
method = NULL,
7070
engine = object$engine,
71-
new = FALSE
71+
check_missing_spec = FALSE
7272
)
7373
}
7474

R/engines.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ set_engine <- function(object, engine, ...) {
130130
mode = object$mode,
131131
method = NULL,
132132
engine = object$engine,
133-
new = FALSE
133+
check_missing_spec = FALSE
134134
)
135135
}
136136

R/misc.R

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,11 +241,12 @@ update_dot_check <- function(...) {
241241
#' @export
242242
#' @keywords internal
243243
#' @rdname add_on_exports
244-
new_model_spec <- function(cls, args, eng_args, mode, method, engine, new = TRUE) {
244+
new_model_spec <- function(cls, args, eng_args, mode, method, engine,
245+
check_missing_spec = TRUE) {
245246

246247
check_spec_mode_engine_val(cls, engine, mode)
247248

248-
if ((!has_loaded_implementation(cls, engine, mode)) && new) {
249+
if ((!has_loaded_implementation(cls, engine, mode)) && check_missing_spec) {
249250
rlang::inform(prompt_missing_implementation(cls, engine, mode))
250251
}
251252

R/update.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,6 @@ update_spec <- function(object, parameters, args_enquo_list, fresh, cls, ...) {
8888
mode = object$mode,
8989
method = NULL,
9090
engine = object$engine,
91-
new = FALSE
91+
check_missing_spec = FALSE
9292
)
9393
}

man/add_on_exports.Rd

Lines changed: 9 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)