Skip to content

Commit 9fef469

Browse files
authored
Add sparse matrix support for LiblineaR engine (#447)
* Add sparse matrix support for LiblineaR engine * Update NEWS * Typo in NEWS
1 parent 47b85dd commit 9fef469

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

NEWS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
* The `liquidSVM` engine for `svm_rbf()` was deprecated due to that package's removal from CRAN. (#425)
66

7-
* A new linear SVM model `svm_linear()` is now available with the `LiblineaR` engine (#424) and the `kernlab` engine (#438), and the `LiblineaR` engine is available for `logistic_reg()` as well (#429).
7+
* A new linear SVM model `svm_linear()` is now available with the `LiblineaR` engine (#424) and the `kernlab` engine (#438), and the `LiblineaR` engine is available for `logistic_reg()` as well (#429). These models can use sparse matrices via `fit_xy()` (#447).
88

99
# parsnip 0.1.5
1010

R/logistic_reg_data.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ set_encoding(
257257
predictor_indicators = "none",
258258
compute_intercept = FALSE,
259259
remove_intercept = FALSE,
260-
allow_sparse_x = FALSE
260+
allow_sparse_x = TRUE
261261
)
262262
)
263263

R/svm_linear_data.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ set_encoding(
6161
predictor_indicators = "none",
6262
compute_intercept = FALSE,
6363
remove_intercept = FALSE,
64-
allow_sparse_x = FALSE
64+
allow_sparse_x = TRUE
6565
)
6666
)
6767

@@ -73,7 +73,7 @@ set_encoding(
7373
predictor_indicators = "none",
7474
compute_intercept = FALSE,
7575
remove_intercept = FALSE,
76-
allow_sparse_x = FALSE
76+
allow_sparse_x = TRUE
7777
)
7878
)
7979

0 commit comments

Comments
 (0)