Merge pull request #395 from tidymodels/glmnet-drop-false

juliasilge · web-flow · commit a82ed4051ec1 · 2020-12-01T08:55:58.000-07:00
Use drop = FALSE for glmnet predictions on single observation
diff --git a/R/linear_reg_data.R b/R/linear_reg_data.R
@@ -168,7 +168,7 @@ set_pred(
     args =
       list(
         object = expr(object$fit),
-        newx = expr(as.matrix(new_data[, rownames(object$fit$beta)])),
+        newx = expr(as.matrix(new_data[, rownames(object$fit$beta), drop = FALSE])),
         type = "response",
         s = expr(object$spec$args$penalty)
       )
diff --git a/R/logistic_reg_data.R b/R/logistic_reg_data.R
@@ -187,7 +187,7 @@ set_pred(
     args =
       list(
         object = expr(object$fit),
-        newx = expr(as.matrix(new_data[, rownames(object$fit$beta)])),
+        newx = expr(as.matrix(new_data[, rownames(object$fit$beta), drop = FALSE])),
         type = "response",
         s = expr(object$spec$args$penalty)
       )
diff --git a/R/multinom_reg_data.R b/R/multinom_reg_data.R
@@ -61,7 +61,7 @@ set_pred(
     args =
       list(
         object = quote(object$fit),
-        newx = quote(as.matrix(new_data[, rownames(object$fit$beta[[1]])])),
+        newx = quote(as.matrix(new_data[, rownames(object$fit$beta[[1]]), drop = FALSE])),
         type = "class",
         s = quote(object$spec$args$penalty)
       )
@@ -80,7 +80,7 @@ set_pred(
     args =
       list(
         object = expr(object$fit),
-        newx = expr(as.matrix(new_data[, rownames(object$fit$beta[[1]])])),
+        newx = expr(as.matrix(new_data[, rownames(object$fit$beta[[1]]), drop = FALSE])),
         type = "response",
         s = expr(object$spec$args$penalty)
       )

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ set_pred(`
`168`	`168`	`args =`
`169`	`169`	`list(`
`170`	`170`	`object = expr(object$fit),`
`171`		`- newx = expr(as.matrix(new_data[, rownames(object$fit$beta)])),`
	`171`	`+ newx = expr(as.matrix(new_data[, rownames(object$fit$beta), drop = FALSE])),`
`172`	`172`	`type = "response",`
`173`	`173`	`s = expr(object$spec$args$penalty)`
`174`	`174`	`)`
Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ set_pred(`
`187`	`187`	`args =`
`188`	`188`	`list(`
`189`	`189`	`object = expr(object$fit),`
`190`		`- newx = expr(as.matrix(new_data[, rownames(object$fit$beta)])),`
	`190`	`+ newx = expr(as.matrix(new_data[, rownames(object$fit$beta), drop = FALSE])),`
`191`	`191`	`type = "response",`
`192`	`192`	`s = expr(object$spec$args$penalty)`
`193`	`193`	`)`